New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rkt fly: add logic to insert environment value #1989

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Projects
None yet
5 participants
@il9ue
Contributor

il9ue commented Jan 16, 2016

Insert environment value by checking related value in Manifest.
Please give any feedback.

Show outdated Hide outdated stage1_fly/run/main.go
Show outdated Hide outdated stage1_fly/run/main.go
Show outdated Hide outdated stage1_fly/run/main.go
@jellonek

This comment has been minimized.

Show comment
Hide comment
@jellonek

jellonek Jan 18, 2016

Contributor

This way You have possibility to insert some values into environ file in time of POD creation, but not in time of entering which is reading already build environ file. This second option is at least needed by any terminal using program (TERM type env variable), so You will have problem with such basic commands like clear (and probably with not-so-simple like screen, tmux - didn't test this) in container after entering into one of POD applications.

Contributor

jellonek commented Jan 18, 2016

This way You have possibility to insert some values into environ file in time of POD creation, but not in time of entering which is reading already build environ file. This second option is at least needed by any terminal using program (TERM type env variable), so You will have problem with such basic commands like clear (and probably with not-so-simple like screen, tmux - didn't test this) in container after entering into one of POD applications.

@alban alban changed the title from add logic to insert environment value to rkt fly: add logic to insert environment value Jan 18, 2016

@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Jan 18, 2016

Member

In the case of rkt fly, there is no need to care about rkt enter.

@steveeJ @krnowak Did you have any plans to refactor some part of rkt fly into the main stage1 to avoid code duplication (#1889)? In that case I don't know if this piece of code will stay.

Member

alban commented Jan 18, 2016

In the case of rkt fly, there is no need to care about rkt enter.

@steveeJ @krnowak Did you have any plans to refactor some part of rkt fly into the main stage1 to avoid code duplication (#1889)? In that case I don't know if this piece of code will stay.

Show outdated Hide outdated stage1_fly/run/main.go
Show outdated Hide outdated stage1_fly/run/main.go
@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Jan 21, 2016

Member

@il9ue Thanks for the update! I added a couple of suggestions.

Member

alban commented Jan 21, 2016

@il9ue Thanks for the update! I added a couple of suggestions.

@il9ue

This comment has been minimized.

Show comment
Hide comment
@il9ue

il9ue Jan 21, 2016

Contributor

@alban Just updated and applied from suggestions and made changes! Thanks for specific feedback!

Contributor

il9ue commented Jan 21, 2016

@alban Just updated and applied from suggestions and made changes! Thanks for specific feedback!

Show outdated Hide outdated stage1_fly/run/main.go
@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Jan 21, 2016

Member

LGTM

Member

iaguis commented Jan 21, 2016

LGTM

@iaguis iaguis modified the milestones: v0.16.0, v1.0.0 Jan 21, 2016

iaguis added a commit that referenced this pull request Jan 21, 2016

Merge pull request #1989 from il9ue/master
rkt fly: add logic to insert environment value

@iaguis iaguis merged commit 4bc5c03 into rkt:master Jan 21, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment