New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change getting started guide to build a static binary #2605

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
2 participants
@matthaias
Contributor

matthaias commented May 10, 2016

Current build command would not work after #2506

Fixes #2584

@alban Can you please take a look at my PR. I am not sure if this is what you wanted, but i tried to build hello with the new build command an it worked for me. Please let me know if there is something wrong with my PR. Thanks!

docs: Change getting started guide to build a static binary
Current build command would not work after #2506

Fixes #2584
@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle May 10, 2016

Contributor

LGTM. Thanks!

Contributor

jonboulle commented May 10, 2016

LGTM. Thanks!

@jonboulle jonboulle merged commit 9d20f08 into rkt:master May 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@matthaias matthaias deleted the matthaias:fix-getting-started-guide-with-static-build branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment