New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example to run multiple apps in one pod #2609

Merged
merged 2 commits into from May 11, 2016

Conversation

Projects
None yet
2 participants
@matthaias
Contributor

matthaias commented May 11, 2016

A example was missing how to run multiple apps in one pod

Fixes #2583

@jonboulle Please take a look. I hope you thought about something like that.

docs: Add example to run multiple apps in one pod
A example was missing how to run multiple apps in one pod

Fixes #2583
Show outdated Hide outdated Documentation/subcommands/run.md Outdated
@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle May 11, 2016

Contributor

thanks! looks good, two short comments

Contributor

jonboulle commented May 11, 2016

thanks! looks good, two short comments

docs: Change level of "run multiple apps in same pod", add preamble
"run multiple apps in same pod" should be higher level

Fixes #2583
@matthaias

This comment has been minimized.

Show comment
Hide comment
@matthaias

matthaias May 11, 2016

Contributor

Sure, i took your preamble example. Thanks for reviewing!

Contributor

matthaias commented May 11, 2016

Sure, i took your preamble example. Thanks for reviewing!

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle May 11, 2016

Contributor

Thanks! LGTM, skipping CI as this is just a docs change.

Contributor

jonboulle commented May 11, 2016

Thanks! LGTM, skipping CI as this is just a docs change.

@jonboulle jonboulle merged commit 5991563 into rkt:master May 11, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
semaphoreci The build passed on Semaphore.
Details

@matthaias matthaias deleted the matthaias:add-example-to-run-more-apps-in-one-pod branch May 11, 2016

tmrts added a commit to tmrts/rkt that referenced this pull request May 25, 2016

docs: Add example to run multiple apps in one pod (rkt#2609)
* docs: Add example to run multiple apps in one pod

A example was missing how to run multiple apps in one pod

Fixes rkt#2583

* docs: Change level of "run multiple apps in same pod", add preamble

"run multiple apps in same pod" should be higher level

Fixes rkt#2583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment