New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: check current working directory #2674

Merged
merged 1 commit into from May 24, 2016

Conversation

Projects
None yet
5 participants
@iaguis
Member

iaguis commented May 23, 2016

Add a new test to check that the WorkingDirectory specified in the ACI
manifest is used.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle May 23, 2016

Contributor

lgtm

Contributor

jonboulle commented May 23, 2016

lgtm

Show outdated Hide outdated tests/inspect/inspect.go Outdated
@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts May 23, 2016

Contributor

LGTM other than a nit

Contributor

tmrts commented May 23, 2016

LGTM other than a nit

tests: check current working directory
Add a new test to check that the WorkingDirectory specified in the ACI
manifest is used.
@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis May 23, 2016

Member

Updated.

Member

iaguis commented May 23, 2016

Updated.

@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts May 24, 2016

Contributor

@iaguis semaphore test failed, due to an unrelated reason (AFAIK)

Contributor

tmrts commented May 24, 2016

@iaguis semaphore test failed, due to an unrelated reason (AFAIK)

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab May 24, 2016

Member
test timed out after 45m0s
Member

lucab commented May 24, 2016

test timed out after 45m0s
@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis May 24, 2016

Member

Let's rebuild!

Member

iaguis commented May 24, 2016

Let's rebuild!

@iaguis iaguis merged commit 4c9fe7e into rkt:master May 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts May 24, 2016

Contributor

@lucab I could've sworn that I saw certificate errors, hmm

Contributor

tmrts commented May 24, 2016

@lucab I could've sworn that I saw certificate errors, hmm

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab May 24, 2016

Member

@tmrts Yes, I think I saw it too, but it wasn't the culprit there. I don't know where that is coming from, but I've already observed it locally, without triggering test failures.

Member

lucab commented May 24, 2016

@tmrts Yes, I think I saw it too, but it wasn't the culprit there. I don't know where that is coming from, but I've already observed it locally, without triggering test failures.

@lucab lucab unassigned tmrts Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment