New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/vagrant: use rkt binary for getting started #2808

Merged
merged 1 commit into from Jun 21, 2016

Conversation

Projects
None yet
8 participants
@s-urbaniak
Contributor

s-urbaniak commented Jun 16, 2016

Currently to get started with rkt we recommend using "vagrant up". This
tries to build rkt inside a virtual machine.

This cleans up the install-vagrant.sh script to use a released version
of rkt instead.

It also removes scripts not being used any more.

Fixes #2789

Show outdated Hide outdated Vagrantfile
@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jun 16, 2016

Contributor

very happy to see all the red!

Contributor

jonboulle commented Jun 16, 2016

very happy to see all the red!

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 16, 2016

Member

Tested the tutorial end-to-end on a fresh vagrant setup, and seems to work fine.

Member

lucab commented Jun 16, 2016

Tested the tutorial end-to-end on a fresh vagrant setup, and seems to work fine.

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 16, 2016

Contributor

Comment to myself: also find a way to easily forward to the Vagrant's internal network, so started pods can be reached from the host.

Contributor

s-urbaniak commented Jun 16, 2016

Comment to myself: also find a way to easily forward to the Vagrant's internal network, so started pods can be reached from the host.

@tmrts tmrts self-assigned this Jun 17, 2016

@philips

This comment has been minimized.

Show comment
Hide comment
@philips
Contributor

philips commented Jun 17, 2016

@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts Jun 17, 2016

Contributor

Went through the tutorial after installing vagrant in macbook, and seems to work fine.

Contributor

tmrts commented Jun 17, 2016

Went through the tutorial after installing vagrant in macbook, and seems to work fine.

@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts Jun 17, 2016

Contributor

@s-urbaniak I missed the discussion regarding the removal of scripts, were they not used by testing infra?

Contributor

tmrts commented Jun 17, 2016

@s-urbaniak I missed the discussion regarding the removal of scripts, were they not used by testing infra?

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 17, 2016

Contributor

@tmrts ack, they're apparently not used by the test infra, @alban checked this.

Contributor

s-urbaniak commented Jun 17, 2016

@tmrts ack, they're apparently not used by the test infra, @alban checked this.

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 17, 2016

Contributor

@tmrts Do you mind to recheck whether the private network stuff works on Vagrant@OSX?

Contributor

s-urbaniak commented Jun 17, 2016

@tmrts Do you mind to recheck whether the private network stuff works on Vagrant@OSX?

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 18, 2016

Contributor

Some changes:

  • To have a better story for Ubuntu/Debian users I renamed install-vagrant.sh to the existing but unused install-rkt.sh script, using checkinstall to create a rkt Debian package.
  • Included the description to use install-rkt.sh on Debian/Ubuntu flavors.
Contributor

s-urbaniak commented Jun 18, 2016

Some changes:

  • To have a better story for Ubuntu/Debian users I renamed install-vagrant.sh to the existing but unused install-rkt.sh script, using checkinstall to create a rkt Debian package.
  • Included the description to use install-rkt.sh on Debian/Ubuntu flavors.
Show outdated Hide outdated scripts/install-rkt.sh
@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts Jun 18, 2016

Contributor

@s-urbaniak I'm getting unable to resolve host ubuntu-xenial

Contributor

tmrts commented Jun 18, 2016

@s-urbaniak I'm getting unable to resolve host ubuntu-xenial

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 18, 2016

Contributor

@tmrts Thanks, I can reproduce this; seems to be an upstream bug https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1561250

Contributor

s-urbaniak commented Jun 18, 2016

@tmrts Thanks, I can reproduce this; seems to be an upstream bug https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1561250

@chancez

This comment has been minimized.

Show comment
Hide comment
@chancez

chancez Jun 19, 2016

Contributor

Now that the rkt-in-rktscripts exist, it should be pretty easy to get all the build dependencies encapsulated in containers, so for people who used the VM for development previously, is it now expected to build rkt inside a rkt container rather directly on the VM host?

Contributor

chancez commented Jun 19, 2016

Now that the rkt-in-rktscripts exist, it should be pretty easy to get all the build dependencies encapsulated in containers, so for people who used the VM for development previously, is it now expected to build rkt inside a rkt container rather directly on the VM host?

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jun 20, 2016

Contributor

@chancez that's one possibility, though @tmrts works on a separate vagrant dev profile.

Contributor

s-urbaniak commented Jun 20, 2016

@chancez that's one possibility, though @tmrts works on a separate vagrant dev profile.

@tmrts

This comment has been minimized.

Show comment
Hide comment
@tmrts

tmrts Jun 20, 2016

Contributor

LGTM after @philips' comments

Contributor

tmrts commented Jun 20, 2016

LGTM after @philips' comments

@tmrts tmrts added the reviewed/lgtm label Jun 20, 2016

Documentation/vagrant: use rkt binary for getting started
Currently to get started with rkt we recommend using "vagrant up". This
tries to build rkt inside a virtual machine.

This cleans up the install-vagrant.sh script to use a released version
of rkt instead.

It also removes scripts not being used any more.

Fixes #2789

@s-urbaniak s-urbaniak merged commit 2d1de5f into rkt:master Jun 21, 2016

11 checks passed

Jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
debian-8-flavor-coreos (i-1dd7a4a8) Success!
Details
debian-8-flavor-coreos (i-c5d0a370) Success!
Details
fedora-22-flavor-coreos (i-53dba8e6) Success!
Details
fedora-22-flavor-coreos (i-d2e59667) Success!
Details
fedora-23-flavor-coreos (i-98d7a42d) Success!
Details
fedora-23-flavor-coreos (i-e6e99a53) Success!
Details
fedora-24-flavor-coreos (i-40d0a3f5) Success!
Details
fedora-24-flavor-coreos (i-ded7a46b) Success!
Details
semaphoreci The build passed on Semaphore.
Details

@s-urbaniak s-urbaniak deleted the s-urbaniak:vagrant branch Jun 21, 2016

@@ -16,6 +16,10 @@ cd rkt-v1.8.0
./rkt help
```
Like most applications, the easiest way to run rkt is to install it with your system's package manager, like apt on Debian or dnf on Fedora. If your distribution doesn't include a rkt package, or your operating system isn't Linux at all, running rkt in a Vagrant virtual machine can be nearly as simple. The instructions below start a virtual machine with rkt installed and ready to run.

This comment has been minimized.

@philips

philips Jun 21, 2016

Contributor

These are separate use cases. There are three use cases:

  1. I want the latest rkt on my machines: download from the GitHub tarballs
  2. I want my official package, install from apt or dnf
  3. I don't have a linux machine, use vagrant.
@philips

philips Jun 21, 2016

Contributor

These are separate use cases. There are three use cases:

  1. I want the latest rkt on my machines: download from the GitHub tarballs
  2. I want my official package, install from apt or dnf
  3. I don't have a linux machine, use vagrant.

This comment has been minimized.

@s-urbaniak

s-urbaniak Jun 21, 2016

Contributor

@joshix do you mind helping with rephrasing this paragraph?

@s-urbaniak

s-urbaniak Jun 21, 2016

Contributor

@joshix do you mind helping with rephrasing this paragraph?

This comment has been minimized.

@lucab

lucab Jun 21, 2016

Member

Point 1 is even more nuanced, as we just offer amd64 binaries here. We are getting support for arm64 as a first class citizen arch, and Debian already builds rkt for way many more arches.

@lucab

lucab Jun 21, 2016

Member

Point 1 is even more nuanced, as we just offer amd64 binaries here. We are getting support for arm64 as a first class citizen arch, and Debian already builds rkt for way many more arches.

This comment has been minimized.

@joshix

joshix Jun 21, 2016

Contributor

Yes, I'll address in a PR with a light rewrite of this doc.

@joshix

joshix Jun 21, 2016

Contributor

Yes, I'll address in a PR with a light rewrite of this doc.

joshix added a commit to joshix/rkt that referenced this pull request Jun 22, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808, rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 22, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808, rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 22, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808, rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 22, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 28, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 28, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

joshix added a commit to joshix/rkt that referenced this pull request Jun 29, 2016

Documentation/trying-out-rkt: Update for clarity and style
Addressing rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

@lucab lucab unassigned tmrts Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment