New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/trying-out-rkt: Update for clarity and style #2825

Merged
merged 1 commit into from Jun 29, 2016

Conversation

Projects
None yet
7 participants
@joshix
Contributor

joshix commented Jun 22, 2016

Addressing #2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.

@alban alban added this to the v1.9.0 milestone Jun 22, 2016

@tmrts tmrts self-assigned this Jun 23, 2016

Show outdated Hide outdated Documentation/trying-out-rkt.md Outdated

@lucab lucab self-assigned this Jun 23, 2016

@tmrts tmrts removed their assignment Jun 23, 2016

@lucab lucab modified the milestones: v1.10.0, v1.9.0 Jun 23, 2016

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 24, 2016

Member

@philips @jonboulle I had a quick chat with @joshix and the new wording should clarify the split between writing arch-agnostic code and distributing pre-compiled binaries. If it sounds ok for you, we can just squash this here.

Member

lucab commented Jun 24, 2016

@philips @jonboulle I had a quick chat with @joshix and the new wording should clarify the split between writing arch-agnostic code and distributing pre-compiled binaries. If it sounds ok for you, we can just squash this here.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jun 27, 2016

Contributor

@squeed Review on this would be appreciated since you're new to this

Contributor

jonboulle commented Jun 27, 2016

@squeed Review on this would be appreciated since you're new to this

Show outdated Hide outdated Documentation/trying-out-rkt.md Outdated
Show outdated Hide outdated Documentation/trying-out-rkt.md Outdated
@squeed

This comment has been minimized.

Show comment
Hide comment
@squeed

squeed Jun 28, 2016

Contributor

I gave this a quick review, as I'm currently in the process of bringing myself on-board. Ultimately, it probably would have been more helpful if there was a stronger step-by-step feel with better indication as to what is "deeper". However, I'm not sure it's that important or worth additional time.

Contributor

squeed commented Jun 28, 2016

I gave this a quick review, as I'm currently in the process of bringing myself on-board. Ultimately, it probably would have been more helpful if there was a stronger step-by-step feel with better indication as to what is "deeper". However, I'm not sure it's that important or worth additional time.

@joshix

This comment has been minimized.

Show comment
Hide comment
@joshix

joshix Jun 28, 2016

Contributor

(rebased)

Contributor

joshix commented Jun 28, 2016

(rebased)

## Using rkt on Linux
rkt consists of a single CLI tool and can run on different platforms. The primary target platform currently is amd64 Linux. A modern kernel is required but there should be no other system dependencies.
rkt is written in Go and can be compiled for several CPU architectures. The rkt project distributes binaries for amd64. These rkt binaries will run on any modern Linux amd64 kernel.

This comment has been minimized.

@krnowak

krnowak Jun 29, 2016

Collaborator

#2758 (arm64 support) is merged, so it needs an update.

@krnowak

krnowak Jun 29, 2016

Collaborator

#2758 (arm64 support) is merged, so it needs an update.

This comment has been minimized.

@lucab

lucab Jun 29, 2016

Member

Not until we sort out if/how we pre-compile and distribute arm64 binaries.

@lucab

lucab Jun 29, 2016

Member

Not until we sort out if/how we pre-compile and distribute arm64 binaries.

This comment has been minimized.

@krnowak

krnowak Jun 29, 2016

Collaborator

Ah true. I was too hasty.

@krnowak

krnowak Jun 29, 2016

Collaborator

Ah true. I was too hasty.

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 29, 2016

Member

@joshix can you please squash them into a single commit? LGTM otherwise.

Member

lucab commented Jun 29, 2016

@joshix can you please squash them into a single commit? LGTM otherwise.

Documentation/trying-out-rkt: Update for clarity and style
Addressing #2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.
@joshix

This comment has been minimized.

Show comment
Hide comment
@joshix

joshix Jun 29, 2016

Contributor

@lucab squished

Contributor

joshix commented Jun 29, 2016

@lucab squished

@lucab lucab added reviewed/lgtm and removed needs/review labels Jun 29, 2016

@lucab lucab merged commit 1369b6f into rkt:master Jun 29, 2016

11 checks passed

Jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
debian-8-flavor-coreos (i-a89ed91d) Success!
Details
debian-8-flavor-coreos (i-ec9ed959) Success!
Details
fedora-22-flavor-coreos (i-c29bdc77) Success!
Details
fedora-22-flavor-coreos (i-cd9ed978) Success!
Details
fedora-23-flavor-coreos (i-0b9bdcbe) Success!
Details
fedora-23-flavor-coreos (i-1b9cdbae) Success!
Details
fedora-24-flavor-coreos (i-9c9add29) Success!
Details
fedora-24-flavor-coreos (i-cc9ed979) Success!
Details
semaphoreci The build passed on Semaphore.
Details

@joshix joshix deleted the joshix:tryoutrw branch Jul 5, 2016

@lucab lucab unassigned squeed Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment