New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/cgroup: add mountFsRO() helper function #2829

Merged
merged 1 commit into from Jun 24, 2016

Conversation

Projects
None yet
4 participants
@0xAX
Contributor

0xAX commented Jun 22, 2016

There are some places in the common/cgroup/cgroup.go which contain the same
code which collects flags to mount a filesystem in read-only mode and calls
mount system call with the given flags and a filesystem source/target.

This patch adds mountFsRO() helper function to prevent code duplication.

Signed-off-by: Alexander Kuleshov kuleshovmail@gmail.com

Show outdated Hide outdated common/cgroup/cgroup.go Outdated

@jonboulle jonboulle added this to the v1.10.0 milestone Jun 23, 2016

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jun 23, 2016

Contributor

thanks! one small comment but lgtm after that

Contributor

jonboulle commented Jun 23, 2016

thanks! one small comment but lgtm after that

common/cgroup: add mountFsRO() helper function
There are some places in the common/cgroup/cgroup.go which contain the same
code which collects flags to mount a filesystem in read-only mode and calls
mount system call with the given flags and a filesystem source/target.

This patch adds mountFsRO() helper function to prevent code duplication.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX

This comment has been minimized.

Show comment
Hide comment
@0xAX

0xAX Jun 23, 2016

Contributor

@jonboulle updated

Contributor

0xAX commented Jun 23, 2016

@jonboulle updated

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jun 23, 2016

Contributor

LGTM but as there's a release going on today let's hold off on merging until after that

Contributor

jonboulle commented Jun 23, 2016

LGTM but as there's a release going on today let's hold off on merging until after that

@rktbot

This comment has been minimized.

Show comment
Hide comment
@rktbot

rktbot Jun 24, 2016

Can one of the admins verify this patch?

rktbot commented Jun 24, 2016

Can one of the admins verify this patch?

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 24, 2016

Member

ok to test

Member

lucab commented Jun 24, 2016

ok to test

@lucab lucab merged commit 9249220 into rkt:master Jun 24, 2016

11 checks passed

Jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
debian-8-flavor-coreos (i-97047a22) Success!
Details
debian-8-flavor-coreos (i-bc027c09) Success!
Details
fedora-22-flavor-coreos (i-94047a21) Success!
Details
fedora-22-flavor-coreos (i-f5790740) Success!
Details
fedora-23-flavor-coreos (i-05027cb0) Success!
Details
fedora-23-flavor-coreos (i-ee047a5b) Success!
Details
fedora-24-flavor-coreos (i-68037ddd) Success!
Details
fedora-24-flavor-coreos (i-6b047ade) Success!
Details
semaphoreci The build passed on Semaphore.
Details

@0xAX 0xAX deleted the 0xAX:cgroup-remount-helper branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment