New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove unused GetImageIDs() #2834

Merged
merged 1 commit into from Jun 24, 2016

Conversation

Projects
None yet
3 participants
@0xAX
Contributor

0xAX commented Jun 23, 2016

This patch removes apps.GetImageIds() method as it has no callers anymore.
This helper was added to pass list of image ids to the state0, but now we
pass list of apps in a pod instead.

Last user of the GetImageIDs() was removed in the 227fe3c commit
( Move pod registration from stage1 to stage0. by @eyakubovich ) and it is
not used anywhere anymore.

So we can remove it.

common: remove unused GetImageIDs()
This patch removes apps.GetImageIds() method as it has no callers anymore.
This helper was added to pass list of image ids to the state0, but now we
pass list of apps in a pod instead.

Last user of the GetImageIDs() was removed in the 227fe3c commit
( Move pod registration from stage1 to stage0. by @eyakubovich ) and it is
not used anywhere anymore.

So we can remove it.
@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 24, 2016

Member

Good catch!

Member

lucab commented Jun 24, 2016

Good catch!

@rktbot

This comment has been minimized.

Show comment
Hide comment
@rktbot

rktbot Jun 24, 2016

Can one of the admins verify this patch?

rktbot commented Jun 24, 2016

Can one of the admins verify this patch?

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jun 24, 2016

Member

ok to test

Member

lucab commented Jun 24, 2016

ok to test

@lucab lucab added this to the v1.10.0 milestone Jun 24, 2016

@lucab lucab merged commit 1cbbf03 into rkt:master Jun 24, 2016

11 checks passed

Jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
debian-8-flavor-coreos (i-0c7f01b9) Success!
Details
debian-8-flavor-coreos (i-760779c3) Success!
Details
fedora-22-flavor-coreos (i-1f0779aa) Success!
Details
fedora-22-flavor-coreos (i-5f017fea) Success!
Details
fedora-23-flavor-coreos (i-80077935) Success!
Details
fedora-23-flavor-coreos (i-aa7c021f) Success!
Details
fedora-24-flavor-coreos (i-0d7f01b8) Success!
Details
fedora-24-flavor-coreos (i-81077934) Success!
Details
semaphoreci The build passed on Semaphore.
Details

@0xAX 0xAX deleted the 0xAX:get-rid-of-unused-functions-from-apps branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment