New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use appc schema instead of string templates #3520

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
5 participants
@ybubnov
Contributor

ybubnov commented Jan 7, 2017

This patch introduces a new package "pkg/aci/acitest" used to set the
default parameters to the application container image manifest
(precisely: name, version, kind).

It replaces the strings templates used to mock the manifest's JSON to
the types from "github.com/appc/schema" go-package.

Fixes #714

@rktbot

This comment has been minimized.

Show comment
Hide comment
@rktbot

rktbot Jan 7, 2017

Can one of the admins verify this patch?

rktbot commented Jan 7, 2017

Can one of the admins verify this patch?

@s-urbaniak

This comment has been minimized.

Show comment
Hide comment
@s-urbaniak

s-urbaniak Jan 9, 2017

Contributor

ok to test

Contributor

s-urbaniak commented Jan 9, 2017

ok to test

@s-urbaniak s-urbaniak added this to the v1.23.0 milestone Jan 9, 2017

Show outdated Hide outdated pkg/aci/aci.go
@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jan 10, 2017

Member

@ybubnov thank you very much for this PR. Just a minor request to make the version label manageable by script, otherwise looks fine 👍.

Member

lucab commented Jan 10, 2017

@ybubnov thank you very much for this PR. Just a minor request to make the version label manageable by script, otherwise looks fine 👍.

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jan 10, 2017

Member

@jonboulle is there anything else missing from #714 after this?

Member

lucab commented Jan 10, 2017

@jonboulle is there anything else missing from #714 after this?

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jan 10, 2017

Contributor

Seems good to me!

Contributor

jonboulle commented Jan 10, 2017

Seems good to me!

@ybubnov

This comment has been minimized.

Show comment
Hide comment
@ybubnov

ybubnov Jan 11, 2017

Contributor

Addressed the review comments and squashed the changes into the single commit.

Contributor

ybubnov commented Jan 11, 2017

Addressed the review comments and squashed the changes into the single commit.

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jan 11, 2017

Member

Ah, I forgot about AppContainerVersion, even better.

Member

lucab commented Jan 11, 2017

Ah, I forgot about AppContainerVersion, even better.

Yakau Bubnou
tests: use appc schema instead of string templates
This patch introduces a new package "pkg/aci/acitest" used to set the
default parameters to the application container image manifest
(precisely: name, version, kind).

It replaces the strings templates used to mock the manifest's JSON to
the types from "github.com/appc/schema" go-package.
@lucab

lucab approved these changes Jan 13, 2017

LGTM and thanks a lot for the cleanup!

@lucab lucab merged commit 1ecd718 into rkt:master Jan 13, 2017

8 checks passed

Jenkins Build finished.
Details
Jenkins (debian-testing, coreos flavor) Success!
Details
Jenkins (fedora-23, coreos flavor) Success!
Details
Jenkins (fedora-24, coreos flavor) Success!
Details
Jenkins (fedora-24, fly flavor) Success!
Details
Jenkins (fedora-rawhide, coreos flavor) Success!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@ybubnov ybubnov deleted the ybubnov:acitest-helpers-instead-of-strings-in-tests branch Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment