New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-service: stop erroring when a pod is running #3525

Merged
merged 1 commit into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@squeed
Contributor

squeed commented Jan 10, 2017

Fixes #3504

This silences this silly error message. This logic isn't exactly correct, but I've filed another issue to fix that.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jan 10, 2017

Contributor

I don't understand, this is going to assign a 0 exit value isn't it?

Contributor

jonboulle commented Jan 10, 2017

I don't understand, this is going to assign a 0 exit value isn't it?

@squeed

This comment has been minimized.

Show comment
Hide comment
@squeed

squeed Jan 10, 2017

Contributor

It already does. The error message just pollutes stderr - it doesn't change the behavior.

Contributor

squeed commented Jan 10, 2017

It already does. The error message just pollutes stderr - it doesn't change the behavior.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Jan 10, 2017

Contributor
Contributor

jonboulle commented Jan 10, 2017

@lucab

lucab approved these changes Jan 11, 2017

LGTM with the caveat that the whole surrounding logic needs to be revamped as per #3524.

@lucab lucab added this to the v1.23.0 milestone Jan 11, 2017

@squeed

This comment has been minimized.

Show comment
Hide comment
@squeed

squeed Jan 11, 2017

Contributor

The only failure is our good friend, TestAppUserSandbox. This is "green".

Contributor

squeed commented Jan 11, 2017

The only failure is our good friend, TestAppUserSandbox. This is "green".

@squeed squeed merged commit 03cfc3d into rkt:master Jan 11, 2017

6 of 8 checks passed

Jenkins Build finished.
Details
Jenkins (debian-testing, coreos flavor) Failure :(
Details
Jenkins (fedora-23, coreos flavor) Success!
Details
Jenkins (fedora-24, coreos flavor) Success!
Details
Jenkins (fedora-24, fly flavor) Success!
Details
Jenkins (fedora-rawhide, coreos flavor) Success!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment