list: add ip of non-running pods to status output #3857
Conversation
What happens if you change https://github.com/rkt/rkt/blob/master/pkg/pod/pods.go?utf8=%E2%9C%93#L272 from |
@squeed thanks for reviewing the PR. I have made changes as you suggested. |
Works for me. Can you add a test to |
01529d2
to
f8e886a
{ | ||
"list --format=json", | ||
true, | ||
podUuid |
iaguis
Dec 18, 2017
Member
Can you add a comma here so tests pass?
Can you add a comma here so tests pass?
12ea62a
to
0a2ede8
It seems your change breaks We should modify the API service to populate network information on exited pods, like we do for running ones. |
@iaguis Thanks for helping me out. Now the test is passing. please review the PR. |
lgtm But can you make your commit follow our convention? We also try to prefer imperative in titles: like "add ip of non running"... Thanks! |
This will be useful for testing the list command to check the ip of the non running pod
@iaguis I have made changes, please check |
Thanks! |
partial fix for #3550
ip of the non running pod is added to the json output