list: add ip of non-running pods to status output

[sch00lb0y]

partial fix for #3550
ip of the non running pod is added to the json output

[squeed]

What happens if you change https://github.com/rkt/rkt/blob/master/pkg/pod/pods.go?utf8=%E2%9C%93#L272 from if p.isRunning() to if p.isRunning() || p.isExited()? Would that accomplish the same thing?

[sch00lb0y]

@squeed thanks for reviewing the PR. I have made changes as you suggested.

[squeed]

Works for me. Can you add a test to rkt_list_test.go? Then this can be merged.

[iaguis]

Can you add a comma here so tests pass?

[sch00lb0y]

@squeed I have added the test case. @iaguis I have made the changes. the test is passing in my local environment but it's failing in the semaphore

[iaguis]

It seems your change breaks TestAPIServiceCgroup. The reason is that we now consider network information for exited pods but the API service doesn't, so the test fails because the info returned by the API service doesn't match the one returned by rkt status.

We should modify the API service to populate network information on exited pods, like we do for running ones.

[sch00lb0y]

@iaguis Thanks for helping me out. Now the test is passing. please review the PR.

[iaguis]

lgtm

But can you make your commit follow our convention?

We also try to prefer imperative in titles: like "add ip of non running"...

Thanks!

[sch00lb0y]

@iaguis I have made changes, please check

[iaguis]

Thanks!