Refrain from needless SOCKS5 warning

rl1987 · Jun 3, 2017 · 9e2f78092395d1250f08a21815ab1145409530eb · 9e2f780
1 parent 1763aa0
commit 9e2f78092395d1250f08a21815ab1145409530eb
Showing with 4 additions and 2 deletions.

+4 −0 changes/bug22461

+0 −2 src/or/buffers.c
diff --git a/changes/bug22461 b/changes/bug22461
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Refrain from needlessly warning Tor controller about passing
+      IP addresses as FQDNs through SOCKS5 interface. Fixes bug
+      22461, bugfix on Tor 0.2.6.2-alpha.
diff --git a/src/or/buffers.c b/src/or/buffers.c
@@ -1686,8 +1686,6 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req,
 
           if (string_is_valid_ipv4_address(req->address) ||
               string_is_valid_ipv6_address(req->address)) {
-            log_unsafe_socks_warning(5,req->address,req->port,safe_socks);
-
             if (safe_socks) {
               socks_request_set_socks5_error(req, SOCKS5_NOT_ALLOWED);
               return -1;