Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program will crash if used with invalid parameter #48

Closed
jcrosso opened this issue Oct 19, 2016 · 1 comment
Closed

Program will crash if used with invalid parameter #48

jcrosso opened this issue Oct 19, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@jcrosso
Copy link

jcrosso commented Oct 19, 2016

By chance I've found that 0.9.9 will segfault if used with a bad first parameter (for example "docsis e").
This can be avoided by adding and extra condition to the last match used by the arg's parser (in docsis.c:430):

if (argc && encode_docsis)   {

Cheers
JC

@AdrianSimionov AdrianSimionov self-assigned this Oct 19, 2016
@AdrianSimionov
Copy link
Collaborator

AdrianSimionov commented Oct 19, 2016

I will have to check if its the only bad parameter which generates a segmentation fault.

Thanks for reporting.

@AdrianSimionov AdrianSimionov added this to the 1.0 Release milestone Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants