Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to last version of the decompress library #18

Closed
rlepigre opened this issue Jul 9, 2018 · 5 comments · Fixed by #23
Closed

Port to last version of the decompress library #18

rlepigre opened this issue Jul 9, 2018 · 5 comments · Fixed by #23

Comments

@rlepigre
Copy link
Owner

rlepigre commented Jul 9, 2018

see ocaml/opam-repository#12313.

@cfcs
Copy link
Collaborator

cfcs commented Jul 19, 2018

This will require an explicit bound on either decompress <= 0.7.0 or (preferably) decompress >= 0.8.0 to prevent situations where we try to compile against the wrong version of decompress.

  1. @rlpigre what do you think about including an opam file in the repository?
    This would allow easier linting and CI of imagelib while developing new patches.

  2. I propose adding an imagelib.opam to do this, and ideally also a imagelib-unix.opam package at some point with the Unix-specific things (right now I believe imagelib stopped compiling on mirage again due to the Unix dependency I introduced when fixing the shell injection issue).

@rlepigre
Copy link
Owner Author

@cfcs OK, I'm fine with that.

@vbgl
Copy link

vbgl commented Oct 8, 2019

May this issue be fixed? It would be nice to be able to use “imagelib” with latest “decompress”.

It seems that there is a couple of pull requests that are ready to be merged. Thanks.

@cfcs
Copy link
Collaborator

cfcs commented Oct 9, 2019

I think #23 is ready to be merged, and then we can address @rymdhund's comments in a separate PR.
The reason for not updating that PR is that I have a lot of branches based on #23 that would be tricky to rebase (GIF support, test suite written with @olleolleolle, image scaling, ...).

@rlepigre
Copy link
Owner Author

@cfcs feel free to merge #23, that looks good to me.

@cfcs cfcs closed this as completed in #23 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants