Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirage compatibility by splitting off Unix-dependent functionality #23

Merged
merged 4 commits into from Oct 11, 2019

Conversation

@cfcs
Copy link
Collaborator

@cfcs cfcs commented Mar 11, 2019

This implements Unix-dependent helpers, and introduces a chunk_writer for implementation-independent output.

ping @rlepigre @rymdhund

EDIT: Also fixes #18 fixes #17 fixes #21

Copy link
Contributor

@rymdhund rymdhund left a comment

I think this looks like a nice way to split the core from the unix stuff

with
| End_of_file ->
let offset = pos_in ich in
close_in ich ;

This comment has been minimized.

@rymdhund

rymdhund Mar 12, 2019
Contributor

Do we really want to close the in_channel here? Shouldn't it be the responsibility of the creator of the chunk_reader to call close on it?

And if we do want to close the channel, we probably want the close_in_noerr here

function
| `String x ->
( try Ok (output_string och x) with
| _ -> close_out och; Error `Write_error)

This comment has been minimized.

@rymdhund

rymdhund Mar 12, 2019
Contributor

same as with the close_in above

@rlepigre
Copy link
Owner

@rlepigre rlepigre commented Mar 12, 2019

Sorry, I'm really busy currently, so I probably won't be able to have a proper look until the weekend.

@cfcs cfcs mentioned this pull request May 28, 2019
6 of 14 tasks
@cfcs cfcs merged commit 03fed77 into rlepigre:master Oct 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants