feat(option): add on-changes-option #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlespinasse
requested changes
Oct 18, 2020
runner.sh
Outdated
Comment on lines
12
to
14
| #/ --remove-page-suffix Remove page suffix when possible | ||
| #/ --on-changes Export drawio file only if he's newer than exported files | ||
| #/ (in case of single page file) |
There was a problem hiding this comment.
Rectify the lines order and some typo
Suggested change
| #/ --remove-page-suffix Remove page suffix when possible | |
| #/ --on-changes Export drawio file only if he's newer than exported files | |
| #/ (in case of single page file) | |
| #/ --remove-page-suffix Remove page suffix when possible | |
| #/ (in case of single page file) | |
| #/ --on-changes Export drawio files only if it's newer than exported files |
runner.sh
Outdated
| echo "+++ generate adoc file" | ||
| create_asciidoc_page "$path" "$filename" "$page" "$output_filename" "$output_file" | ||
| echo "image '$output_file.png'" | ||
| if [ "$should_retry" == "false" -a "$ON_CHANGES" == "true" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$should_retry" == "false" -a "$ON_CHANGES" == "true" ]; then | |
| if [ "$should_retry" == "false" ] && [ "$ON_CHANGES" == "true" ]; then |
rlespinasse
approved these changes
Oct 21, 2020
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15
I'm not an expert in shell but this pr do the job, i would like to know your opinion on it :D