New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target object for fluid inflow objects not deleted #405

Closed
lumpynose opened this Issue Dec 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@lumpynose
Copy link

lumpynose commented Dec 14, 2018

System Information

Blender Version (including hash): 2.79b f4dcdf9d68b
FLIP Fluids Version: 9.05 experimental 19-nov-2018
Operating System: windows 10
CPU: intel
GFX: gtx 1070
RAM: 16gb

Describe the bug

If you add a Fluid object and make it the Target Object for a fluid Inflow object, when you delete the Fluid object (I right clicked on it in the Outliner and deleted it) it's not deleted. It's removed from the 3d view but when you run the simulation again its fluid is generated again. You can also see it in the Outliner under Blender File and Data-Blocks under Objects. Although it's not displayed in the All Scenes list in the Outliner. The Target Object could also be an Empty, or probably anything.

After you delete the object from the Inflow's Target Object field then it goes away.

To Reproduce

Create an Inflow object, make its Target Object be some other object, then delete that other object and look for the Target Object in the Outliner under Blender File -> Objects.

Expected Behaviour

If you add an Empty, then add an Icosphere and a Cube, then add a Rigid Body constraint to the Empty then make the Icosphere its Object 1 and the Cube its Object 2, you can then delete either or both of them and they're deleted (you may need to save the blend file and then quit and reopen it). With Flip Fluids the expected behavior would be for the Inflow's Target Object to be fully deleted without first needing to delete from the Inflow panel's Target Object field.

Actual Behaviour

The Inflow's Target Object is only partially deleted.

Screenshots

https://imgur.com/a/bG6biuS

@rlguy

This comment has been minimized.

Copy link
Owner

rlguy commented Dec 14, 2018

Hi lumpynose,

Thanks for the report! That is interesting behaviour and I did not think of this case. The problem is that the addon is looking through all of the objects in the .blend file data when it should actually only be looking through the objects in the scene. This should be easy to resolve, and I'll update this issue when it's fixed!

- Ryan

@rlguy rlguy added the bug label Dec 14, 2018

@rlguy

This comment has been minimized.

Copy link
Owner

rlguy commented Dec 25, 2018

This has been fixed and will be included in the next experimental version (9.0.5.2)!

@rlguy rlguy closed this Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment