Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Incorrect liquid surface scale #414
Blender Version: 2.79b f4dc9f9d68b
Describe the bug
The surface of the fluid does not match the debug particles. This is due to the fact that the scale of the surface is not correct.
Open the blend file and run the simulation.
The scale of the surface must be 1.0
Liquid surface scale is not 1.0
Thanks for the report! I was able to reproduce this error.
This bug is caused by a rounding/precision error when calculating the resolution within the addon. In your scene, the resolution is set to 50. The addon was calculating the resolution to be 50.00000111758712, which was rounded up to 51. This caused the fluid mesh to be scaled up slightly to match the resolution of 51.
This bug has been fixed and will be included in the next update which will be available either this Friday (Jan 25th) or next Friday (Feb 1st).
Thanks for letting me know! I just had a chance to check this out and it looks like this is a result of bad code design. I'm calculating the resolution differently in different areas of the addon/simulator. This is leading to different resolution values which is causing incorrect scale:
I'll redesign how the addon/simulator handles resolution and grid dimension calculations so that that can be fixed in the next version.