New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gnome Shell 3.30 #7

Merged
merged 3 commits into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@aral
Copy link
Contributor

aral commented Dec 29, 2018

Updates extension for Gnome Shell 3.30 while keeping support for earlier versions, using the DisplayWrapper helper from the dash-to-panel extension (https://github.com/home-sweet-gnome/dash-to-panel/blob/5e0f64ed5a8db0cd2808865f1d4cf1f1deee55b7/utils.js#L185)

(For the related issue on the dash-to-panel extension repository, see home-sweet-gnome/dash-to-panel#434)

@aral

This comment has been minimized.

Copy link
Contributor

aral commented Dec 29, 2018

Fixes #6

@aral aral changed the title Add support for Gnome Shell 3.30 WIP: Add support for Gnome Shell 3.30 Dec 29, 2018

@aral

This comment has been minimized.

Copy link
Contributor

aral commented Dec 29, 2018

Please hold off on merging this. I just realised that keybindings are broken also.

The keybindings are not broken, they are just (a) undocumented (b) unexposed + unchangeable (due to the way Gnome Extensions work?) except by viewing and modifying the code (this sounds so implausible to me that I must be missing something but I have a sense of foreboding that I am actually not and this was deemed acceptable at some point in time).

Will add a commit that makes the adding of keybindings more compatible across versions (from when I thought they were broken). And also, will submit a commit that documents the keybindings in the README so that people don’t have to look into the source code to find out how to use the extension.

aral added some commits Dec 29, 2018

@aral aral changed the title WIP: Add support for Gnome Shell 3.30 Add support for Gnome Shell 3.30 Dec 29, 2018

@aral

This comment has been minimized.

Copy link
Contributor

aral commented Dec 29, 2018

OK, this is ready for merge now.

@measlytwerp

This comment has been minimized.

Copy link

measlytwerp commented Dec 29, 2018

If you're interested, the Screenshot Tool implements changable key bindings: https://github.com/OttoAllmendinger/gnome-shell-screenshot/

@aral

This comment has been minimized.

Copy link
Contributor

aral commented Dec 29, 2018

Oh, neat, thank you. Will take a look at how they did it :)

@rliang rliang merged commit bd4fb8c into rliang:master Jan 18, 2019

@rliang

This comment has been minimized.

Copy link
Owner

rliang commented Jan 18, 2019

Thank you!

Will submit to extensions.gnome.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment