Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Leaner, meaner dotjs #19

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

canuckistani commented Apr 4, 2012

I've done a bunch of work refactoring dotjs based on conversations with SDK devs around minimizing memory footprint. These changes feature a few different bits:

  • I switched back to using page-mod and instead bailing out on iframes very early in the content script.
  • I only load jquery into a page if there is a match
  • I separated out the actual matching of filenames to a different module, ideally one could write tests for it.
Owner

rlr commented Apr 4, 2012

Sweet, I'll take a look and hopefully learn a trick or two :-). thanks!

Owner

rlr commented Apr 6, 2012

Woot. I like. I still need to read up on when I should use things like let. As a webdev, I never get to use that :-/.

Squashed and landed: 4dc4f9f

I'll use it for a few days and then submit it to AMO.

@rlr rlr closed this Apr 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment