Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the 128x64 st7567 #71

Merged
merged 5 commits into from Sep 7, 2018
Merged

Conversation

Gadgetoid
Copy link
Contributor

I've added support plus test coverage for the st7567 LCD driver. The driver chip itself can drive a variety of displays/orientations but is usually found paired with a 128x64 pixel, 1-bit LCD display (much like the st7565).

The display rotation is the default- with the black strip and ribbon cable at the top of the display- but can be rotated 180 degrees with --rotate 2.

90 and 270 degree rotation aren't so hot, though. Is there an established pattern for blocking these? An assert(rotate in [0,2]) seems a little clunky since it throws a not-particularly-friendly assertion error.

@Gadgetoid
Copy link
Contributor Author

Oh and before this can be released, it looks like I need the .. versionadded:: X.X.X - should this be the currently released version +1? IE: 1.0.4 in this case?

@rm-hull
Copy link
Owner

rm-hull commented Aug 21, 2018

Nice one ... I'll attend to this next week when I'm back off holidays

@rm-hull
Copy link
Owner

rm-hull commented Sep 4, 2018

@Gadgetoid you could have a scan though the docs and add refernces to ST7567 where appropriate, eg. in:

  • setup.py - the description on line 46
  • doc/install.rst
  • doc/index.rst - title on line 1
  • doc/intro.rst - intro blub on line 3
  • doc/python-usage.rst
  • README.rst

It would be good to source a PDF datasheet and drop that into the https://github.com/rm-hull/luma.lcd/tree/master/doc/tech-spec and update the ref on the intro page too.

Other than that, implementation looks fine 👍

Copy link
Owner

@rm-hull rm-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes

@rm-hull
Copy link
Owner

rm-hull commented Sep 4, 2018

Oh and before this can be released, it looks like I need the .. versionadded:: X.X.X - should this be the currently released version +1? IE: 1.0.4 in this case?

I'll update when I cut a new release, but maybe just add a hardcoded .. versionadded:: X.X.X for now

@rm-hull rm-hull merged commit ed0ab13 into rm-hull:master Sep 7, 2018
@rm-hull
Copy link
Owner

rm-hull commented Sep 7, 2018

Luma.LCD v1.1.0 released:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants