-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize property fetching #31
Comments
…no propertyKeys are used. This has brought some tests to fail, probably indicating a bug in PropertiesStrategy. #31
@seanbarzilay see the failing tests following my changes to an empty set (I accidentally commited this to master...) |
Also, why does |
@rmagen if you know you need a certain property or all properties from a vertex than it doesn't matter when are you querying it's properties |
It does because other steps might filter out the vertex before its needed. But On Jun 27 2016, at 7:56 am, sbarzilay <notifications@github.com> wrote:
|
Current querying behavior
UniGraphVertexPropertiesSideEffectStep
, a step that comes before any step that uses properties, and issues aDeferredVertexQuery
. This ensures that the vertices will only be queried if and when its needed (i.e. lazy loading).Problems
This issue tries to solve problem 1. We should probably create another ticket for solving problem 2 in the future.
Solution suggestion
SearchQuery/SearchVertexQuery/DeferredVertexQuery should pass a list of property keys needed from the queried element.
UniGraphPropertiesStepStrategy
should provide the property lists to the querying steps by analyzing the traversal. Scenarios:null
list.null
list. ???Next, when a Controller receives these queries it should only fetch the relavent properties, or not issue a query at all when possible.
The text was updated successfully, but these errors were encountered: