-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMagick doesn't support HDRI ImageMagick #18
Comments
I'm stuck with the same problem. How does one solve this? |
Having the same issue here on arch linux. Can anyone comment on @bricef's fix? |
@joneshf I have no idea what I'm doing :) My branch is nothing but the patch above applied. I haven't really had a look at it in any depth. Didn't even know that it would be cross referenced here. |
Maybe not, but your branch worked to install over here, so it's worth a look. |
This affects me on recent Arch-Linux. Maintainers decided to enable hdri - have to build it from source now which is very pleasant. Here's the commit on the Arch-side: I don't think that they will change that. Can we achieve a solution on rmagick's side? |
I'm with @jk779. How difficult is this change? What problem does enabling HDRI pose with the current rmagick? |
I also use Arch Linux and would like to see this fixed. 👍 |
Same situation here. |
Please, fix this for Arch Linux :) +watching thread. |
Same here. 👍 |
+1 |
@bricef's Fix works for me on Arch and I have not been able to find any ill effects, using both regular and HDR images. Has anyone issued a pull request to get this patch in to master? |
While I think @bricef should go ahead and create a PR against master, considering there's been no activity on this repo for the past eight months, it might be easier to just use his fork. |
I agree that using @bricef's fork is easier once you've spent the time to find the solution. But to save future developers the time it takes to research the install issue, someone's got the beat a drum to get the root cause fixed. Folks can help get this issue resolved by not only making a little noise, but by confirming that the patch in the Pull Request works, does not cause any production issues, and that you've tested it. Thanks in advance! |
Ran across this while installing Redmine on Arch. Switched to @peteonrails's branch and it installed fine. I don't know what Redmine does with rmagick, but everything seems to work. |
There's a package that fixes this hdri business https://aur.archlinux.org/packages/imagemagick-no-hdri/ |
Ditto for Vimdeck instead of Redmine. |
@joneshf that package is out of date unfortunately Would really like to see this implemented in master branch! |
+1 |
This is now available on the master, I will not yet package it for rubygems until the tests are upgraded. |
@mmaiza Thanks! |
@mmaiza Thank you! |
@mmaiza As I'm not familiar with this gem + gem's tests. What tests need to be upgraded (and how)? Thx. Cheers, |
@mmaiza When are you going to release the update? |
+1 I also use ArchLinux. |
@mmaiza Just wondering when you are going to release this updated gem? |
@mmaiza Bump. |
@bf4 if we don't make any positive movement by the end of next week, lets work on the proposed fork you've created. Please give me commit access if that is okay. |
done |
I'll post a blog post later today on the state of affairs with regards to the development of rmagick (I've had a few talks with the main developer). |
Anything you can share here for a tl;dr? |
The TL;DR is that unless work happens on a fork, no work is going to happen. |
Nice. I've actually got in touch with the original maintainer before @mmaiza and asked him for his suggestions: @baror - he was responsive and hopefully something comes of this communication. I think that the easiest option would be to release one final gem for the 2.x branch and then perhaps focus on the 3.x release. I've actually started using Ruby VIPS which is pretty good but pretty low level. As a community I'm pretty sure we can pull our heads together and make a decent final release for 2.x and then start fixing issues (e.g. tests) for a 3.x release. We could remove a lot of legacy crap (support for ruby 1.5 etc) |
@linduxed Thanks for the detailed information about your communications. It is clear to me that @mmaiza is doing the project a MASSIVE disservice by not updating the gem or working on the project or even communicating. If he isn't capable of writing the code himself he should at least engage the community as much as possible, pass on the responsibility to people who at least are passionate to get the ball rolling. |
@ioquatix I agree. This is a general problem in the Ruby ecosystem, where a project used by many can very easily become abandoned. What's particularly strange, here, is that the whole issue could be fixed if @mmaiza did two things:
I'm involved here, in part, because this is a part I'd like to help solve (or at least ameliorate). See the discussion on the rubygems-org list about creating a rubygems adoption center. https://groups.google.com/d/topic/rubygems-org/niS5ZO9DNgk/discussion Though I'd prefer work continue here, especially since the gem is part of an org, which makes it super easy, I'm also a little excited to test-drive 'adopting' the gem at https://github.com/gemhome/rmagick Adopting a gem is a huge pain. I'd love for there to a be a one-click button for a github repo/gem owner to click and transfer ownership / add as owner someone who can help maintain the gem. |
@baror can you just add me or someone as repo owner (or transfer it to another org) and gem owner and we'll take it from here? |
Hey, everyone - You can find the latest documentation that I know about for how to do a release here: https://github.com/rmagick/rmagick/wiki/Release-Process , but as you can see, it's almost four years old, so it's almost certainly stale. Unfortunately, you need to get a bunch of permissions that only @mmaiza has. From this thread, it seems like the last time you all heard from @mmaiza was in November of last year. Here's my plan:
Does that sound reasonable to everyone? Thanks,
|
@baror sounds like a good plan of action. |
So, I have gem push now. Give me a hash to point to and I'll build a release candidate |
@bf4, I've been using the current master in production using |
Done. http://rubygems.org/gems/rmagick/versions/2.13.3.rc1 I think most of the release process should be deprecated in favor of gem build. need to confirm.. please confirm this release works... I still don't have commit here, so we need to work on a fork, till @mmaiza gives me or someone else access (gem release is essentially unrelated to any repository) |
Ok, I'm going to push a real 2.13.3. I've been looking at what part of the 'release process' is still required. Most of it looks like it can go and be replaced by gem build. The whole redcarpet conversion of README.rc to README.html doesn't seem to have been done for a while... and is buggy, thought it does appear to be at http://www.imagemagick.org/RMagick/doc/ which we (someone) needs to look into updating. I'm moving work to gemhome/rmagick until we get control of this repo. At least we can merge that back in here if we get this back. Hey, @linduxed we're famous! http://rubyweekly.com/issues/206 links to your post http://linduxed.com/blog/2014/07/25/the-state-of-rmagick-development/?utm_source=rubyweekly&utm_medium=email |
I came across this in ruby weekly. Thanks guys, I had some vague ambitions to fork it myself and do some code cleanup. Nice to see it maintained again. |
@mockdeep I'd be very happy to accept a few PRs or issue write-ups there then add you as a collaborator. (If we don't do it, no one will). |
Thanks, I'll add some cards to our team's open source board. I'm particularly interested in code quality and getting the tests passing. It's sad to see so many projects falling away from being maintained. Some I've tried to contribute to only to get radio silence, others people ask if they can maintain and also don't get any response. Seems like there should be some sort of statute of limitations on rubygems for how long a gem can go without an update before it is released to be handled by another willing maintainer. Almost like renewing a domain... |
That's an interesting idea. You post it to the rubygems-org list |
rmagick-2.13.2 is incompatible with versions of ImageMagick built with --enable-hdri. This includes the version of ImageMagick supplied with Arch Linux. This prevents rmagick, and consequently Danbooru, from being installed on Arch Linux. rmagick-2.13.3 fixed this issue. See rmagick/rmagick#18.
I'm trying to get RMagick to work with Fink's imagemagick package, but I get the following error:
Some web searching turns up a patch for pld-linux:
The text was updated successfully, but these errors were encountered: