Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Image#morphology and Image#morphology_channel #24

Open
bf4 opened this Issue Jul 24, 2014 · 5 comments

Comments

Projects
None yet
1 participant
Owner

bf4 commented Jul 24, 2014

Issue by naquad
Friday Dec 02, 2011 at 14:57 GMT
Originally opened as #40


Implementation of Image#morphology and Image#morphology_channel methods, also implemented KernelInfo class used by morphology and bitwise or for enums.


naquad included the following code: https://github.com/rmagick/rmagick/pull/40/commits

Owner

bf4 commented Jul 24, 2014

Comment by rmagick
Friday Dec 02, 2011 at 20:53 GMT


Thanks for doing this. I will merge it once I have gone over it and build some tests for it.

Moncef

-----Original Message-----
From: Daniel Fort [mailto:reply@reply.github.com]
Sent: Friday, December 02, 2011 9:58 AM
To: rmagick
Subject: [rmagick] Image#morphology and Image#morphology_channel (#40)

Implementation of Image#morphology and Image#morphology_channel methods, also implemented KernelInfo class used by morphology and bitwise or for enums.

You can merge this Pull Request by running:

git pull https://github.com/naquad/rmagick master

Or you can view, comment on it, or merge it online at:

#40

-- Commit Summary --

  • added KernelInfo class, added Image#morphology and Image#morphology_channel
  • rdoc comment fix + rb_funcall -> rb_class_new_instance
  • added bitwise OR to enum
  • doc + refactoring

-- File Changes --

M ext/RMagick/rmagick.h (22)
M ext/RMagick/rmenum.c (36)
M ext/RMagick/rmimage.c (72)
A ext/RMagick/rmkinfo.c (247)
M ext/RMagick/rmmain.c (95)

-- Patch Links --

https://github.com/rmagick/rmagick/pull/40.patch
https://github.com/rmagick/rmagick/pull/40.diff


Reply to this email directly or view it on GitHub:
#40

Owner

bf4 commented Jul 24, 2014

Comment by naquad
Saturday Dec 03, 2011 at 02:34 GMT


Ok. Please notify me in case some code needs rewrite / modification.

Owner

bf4 commented Jul 24, 2014

Comment by rmagick
Saturday Dec 03, 2011 at 20:56 GMT


Ok.

-----Original Message-----
From: Daniel Fort [mailto:reply@reply.github.com]
Sent: Friday, December 02, 2011 9:34 PM
To: rmagick
Subject: Re: [rmagick] Image#morphology and Image#morphology_channel (#40)

Ok. Please notify me in case some code needs rewrite / modification.


Reply to this email directly or view it on GitHub:
#40 (comment)

Owner

bf4 commented Jul 24, 2014

Comment by dylancopeland
Monday Jun 17, 2013 at 23:35 GMT


Any update on this? Morphology functionality would be greatly appreciated.

Owner

bf4 commented Jul 24, 2014

Comment by hayesmp
Monday Jan 27, 2014 at 17:10 GMT


@rmagick Can this be merged? EDIT: Oh, I see. Needs tests.

@vassilevsky vassilevsky referenced this issue Apr 5, 2015

Closed

Morphology #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment