Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced volatile VALUE X with RB_GC_GUARD(X) #193

Merged
merged 1 commit into from Apr 26, 2015
Merged

replaced volatile VALUE X with RB_GC_GUARD(X) #193

merged 1 commit into from Apr 26, 2015

Conversation

u338steven
Copy link
Contributor

From #176

I merely replaced volatile VALUE X with RB_GC_GUARD(X).
(Perhaps some RB_GC_GUARD are unnecessary, but status quo for now)

RB_GC_GUARD is only effective on the VALUE data type, not converted C data types.

  1. “volatile” implementations may be buggy/inconsistent in some
    compilers and architectures. RB_GC_GUARD is customizable for broken
    systems/compilers without those without negatively affecting other
    systems.

Appendix E. RB_GC_GUARD to protect from premature GC

@vassilevsky
Copy link
Member

Spectacular! 😍It's as if a magic fairy flew through the source code and sprinkled it with her magic wand! 💫

vassilevsky added a commit that referenced this pull request Apr 26, 2015
@vassilevsky
Merge pull request #193 from gemhome/replace_volatile
d287616 
Replaced `volatile VALUE x` with `RB_GC_GUARD(x)`
@vassilevsky vassilevsky merged commit d287616 into master Apr 26, 2015
@vassilevsky vassilevsky deleted the replace_volatile branch April 26, 2015 08:50
@vassilevsky
Copy link
Member

Thanks @u338steven! You are the boss! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@u338steven @vassilevsky