Fixed: test_convolve(Image2_UT) in Image2.rb fails #72 #98

Merged
merged 1 commit into from Aug 16, 2014

Conversation

Projects
None yet
2 participants

From ImageMagick 6.8.4, this error occurred.
Because some argument validation was deleted.

deleted validation:

  if ((width % 2) == 0)
    ThrowImageException(OptionError,"KernelWidthMustBeAnOddNumber");

effect.c (ImageMagick 6.8.3)
effect.c (ImageMagick 6.8.4)

Therefore, another exception should be raised.
I selected "memory allocation failed" (Allocation size=-1)

assert_raise(Magick::ImageMagickError) { @img.convolve(-1, [1.0, 1.0, 1.0, 1.0]) }

Is this test still relevant?

IS a non-odd kernel size valid now?

ioquatix added a commit that referenced this pull request Aug 16, 2014

Merge pull request #98 from u338steven/patch-2
Fixed: test_convolve(Image2_UT) in Image2.rb fails #72

@ioquatix ioquatix merged commit 98ad048 into rmagick:master Aug 16, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@u338steven u338steven deleted the u338steven:patch-2 branch Aug 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment