Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Memory leak in cURL transport #39
I discovered a memory leak in the cURL transport. When doing multiple
I’ve narrowed it down to
I tried looking for a reference to the transport which is not released but can’t find any.
The temporary solution is to add
Before I fork your repo and add the temporary fix I thought I’d let you know so maybe you can find the real cause of this bug — since you’re more familiar with your code.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
+1 to this. Came across this issue today when trying to use request to download multiple files and was coming across a php error that the system could not open any more files because the curl connections weren't being closed. It should be closed here: https://github.com/rmccue/Requests/blob/master/library/Requests/Transport/cURL.php#L245 but only if "blocking" is set to false? What exactly is the purpose of the "blocking" option and why does the curl connection only get closed if it is set to false?