Improve our tests (round 2) #170

Merged
merged 10 commits into from Oct 2, 2015

Conversation

Projects
None yet
2 participants
@rmccue
Owner

rmccue commented Oct 2, 2015

Massive props to @ozh for his work on #149. Also changed the Portquiz test to use regex instead, since we don't care if the page is valid HTML or not.

ozh and others added some commits Apr 19, 2015

Use mock to test success/failure on status code
This will save **260** outgoing queries to httpbin.org
Use regex to match port string
DOMDocument is prone to crashing with HTML errors, and since we only
care about this tiny bit, might as well use a simpler regex.

@rmccue rmccue added the Testing label Oct 2, 2015

@rmccue rmccue added this to the 1.7 milestone Oct 2, 2015

@rmccue rmccue referenced this pull request Oct 2, 2015

Closed

PHP 7 compatibility #171

rmccue added a commit that referenced this pull request Oct 2, 2015

@rmccue rmccue merged commit 94a3423 into master Oct 2, 2015

3 checks passed

Scrutinizer No new issues
Details
codecov/project 85.73% (no previous report found to compare against)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rmccue rmccue deleted the fix-tests-damn-it branch Oct 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment