Skip to content
Commits on Jul 13, 2012
  1. @TWestling

    Merge "Implemented hashCode methods for events." into internal

    TWestling committed with Gerrit Code Review
  2. @TWestling

    Implemented hashCode methods for events.

    TWestling committed
    Not every event should be considered unique as
    far as the build memory goes. Added an overridden
    hashCode method so that the event type, change,
    patchset and refupdated are all part of generating
    the hashcode for an event.
    
    Change-Id: I6afda82871eef6bae8e540d5a64c8be027305065
Commits on Jul 12, 2012
  1. @dpursehouse

    Merge "Update documentation for consistency" into internal

    dpursehouse committed with Gerrit Code Review
  2. @dpursehouse

    Merge "Add more missing Japanese translations" into internal

    dpursehouse committed with Gerrit Code Review
  3. @dpursehouse

    Update documentation for consistency

    dpursehouse committed
    Make sure references to "Change-Id" and "ref-spec." are consistent
    throughout the documentation.
    
    Change-Id: Ied5a4945d00820135ecf001fb8d369167277b592
  4. @dpursehouse

    Add more missing Japanese translations

    dpursehouse committed
    Add descriptions of the following environment variables in the
    Japanese translation of the main help file:
    
        GERRIT_CHANGE_OWNER
        GERRIT_CHANGE_OWNER_NAME
        GERRIT_CHANGE_OWNER_EMAIL
        GERRIT_PATCHSET_UPLOADER
        GERRIT_PATCHSET_UPLOADER_NAME
        GERRIT_PATCHSET_UPLOADER_EMAIL
    
    Change-Id: I9163a0fb808b8f494950c504ae8f6a6e17aa78f2
Commits on Jul 11, 2012
  1. @TWestling

    Refactorization of GerritTriggeredEvents

    TWestling committed
    Moved out change, patchset and refupdated to
    subclasses, since not all events have these.
    
    Change-Id: I1f212569f39cb89ab7a41c86a64d0f2edbff7488
Commits on Jul 9, 2012
  1. @dpursehouse

    Enable trigger on draft published only when supported by Gerrit

    dpursehouse committed
    The `draft-published` event is only available from Gerrit version
    2.5, so add a check to only enable the feature if supported by
    the current Gerrit version.
    
    Change-Id: I7686542d23a3660b853c2c94e4cd78985257ca87
Commits on Jul 6, 2012
  1. @dpursehouse

    Trigger on `draft-published` by default

    dpursehouse committed
    Update the trigger initialisation to include the draft
    published event as default, in addition to patch set created.
    
    Change-Id: I74d0b5b3eb496dcee7ea55cba7afc65eb90cb7be
Commits on Jul 5, 2012
  1. @dpursehouse

    JENKINS-10055: NPE when commit to build is first commit in repository

    dpursehouse committed
    When the commit to build is the first commit in the repository, it
    does not have a parent commit.  In this case use the revision of
    the commit itself as parent.
    
    Change-Id: I167c02f10e2b657433da63323e04cc7f77733d65
Commits on Jun 27, 2012
  1. @rsandell

    Merge branch 'origin/master' into i

    rsandell committed
    Conflicts:
    	gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java
    	gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java
    
    Change-Id: Id469381ec1fc2e5bece28a20e2614bf847471f03
  2. @rsandell
  3. @dpursehouse

    Remove executable mode flag on files

    dpursehouse committed
    Several .html and .java files have the executable mode flag set,
    possibly as a result of being edited on a Windows system.
    
    Remove the executable flag (chmod -x) on these files.
    
    Change-Id: I2b3cc85ad318daca5da8ad78cb2095a8a9eda891
  4. @dpursehouse

    Add support for triggering on the `draft-published` event

    dpursehouse committed
    The `draft-published` event is fired from Gerrit when a change
    is moved from draft state to new.
    
    Also fix file mode on GerritTrigger.java (was +x).
    
    Change-Id: Ia4c57b546b69a9c35e5b46b01568d158844b788c
  5. @dpursehouse

    Help texts for the Custom Build Message options

    dpursehouse committed
    Add links to the help texts from the config panel.
    
    Also fix file mode on config.jelly (was +x).
    
    Change-Id: I3525e702f22b0699d3f035ec647bd1c7e35f81b2
Commits on Jun 26, 2012
  1. @TWestling

    Config UI changes

    TWestling committed
    Changed from 4 checkboxes to a hetero-list.
    One or more trigger types can be added to a project.
    
    Change-Id: I3889817b0f2256b4cf7079fd3591b5c4a1acf57b
Commits on Jun 25, 2012
  1. @rsandell

    Merge pull request #26 from jhansche/master

    rsandell committed
    Add a new executeCommand variation, that returns the Channel
  2. @rsandell

    Merge pull request #24 from kohsuke/master

    rsandell committed
    Fixed a double-trigger when a project is renamed
Commits on Jun 22, 2012
  1. @jhansche

    Add a new "execute" variation that returns the Channel

    jhansche committed
    This variation returns the SSH Channel, giving access to all 3 streams
    and the exit status.
Commits on Jun 19, 2012
  1. @kohsuke

    Follow up fix: hash code shouldn't be a map key.

    kohsuke committed
    This is a follow-up fix to the previous commit, and one that addresses
    the real underlying problem of using hash codes as the key.
    
    Since add/remove of the listeners are done by passing in the instance,
    the correct thing to do is to use the listener instance itself as the
    identity, hence the use of Set, not Map.
    
    In addition, I made the code to use CopyOnWriteArraySet so that we don't
    have to maintain the code of copying around a set every time we change
    it. It is also probably run faster, as we iterate over them more often
    than change listeners.
Commits on Jun 14, 2012
  1. @kukido

    Merge pull request #25 from dpursehouse/checkstyle-gitignore

    kukido committed
    Add .checkstyle to .gitignore
  2. @dpursehouse
Commits on Jun 12, 2012
  1. @TWestling

    Configurable verdict categories for trigger on comment

    TWestling committed
    It is now possible to define verdict categories in the Gerrit
    management UI. This is used for the trigger-on-comment-added
    configuration in a project.
    
    Change-Id: I44e1127f36f9b70bf1c4f6ff48a9f38470543fda
Commits on Jun 8, 2012
  1. @kohsuke

    Fixed a double-trigger when a project is renamed.

    kohsuke committed
    GerritHandler.gerritEventListeners uses a hash code as the key to
    remember listeners, and GerritTrigger derives hash code from the project
    name.
    
    So when a project is renamed, the hash code changes, and
    GerritTrigger.stop() fails to remove the listener.
    
    This test case and the fix resolves this issue with the minimal change
    to the current code. It uses the project object itself as the source of
    the hash, which works correctly.
    
    This change by itself doesn't touch the bigger underlying design
    problem, that the hash code is used as a key. If two projects have the
    exact same hash code for coincidence (which is legal), then the current
    code doesn't work.
    
    I'm providing this change as the first step to maximize the chance of
    the change inclusion.
Commits on Jun 1, 2012
  1. @rsandell

    Obey the isScorable property of an event.

    rsandell committed
    Will send code review 0 and verified 0 when the event isn't scorable.
    Like for a ChangeMerged event.
    Found some more backwards compatibility issues and fixed those.
    But more tests of loading old jobs and builds are needed.
    
    Change-Id: I1f74cad96d14c122b2646668a033ac3383476a36
Commits on May 30, 2012
  1. @TWestling @rsandell

    Merge branch 'master' into i

    TWestling committed with rsandell
    Change-Id: I250ee3f1d08714e89663c07ccadf2293d7c5ead1
Commits on May 29, 2012
  1. @TWestling

    Fix behavior of canceling old patch sets

    Brad Larson committed with TWestling
    There were several problems with canceling jobs created by old patch sets
    when new patch sets are uploaded.
    
    We were removing old jobs when scheduled() was called, but then removed()
    was also called, which would cancel the newly-added build we care about.
    Instead, we now store the PatchsetCreated event to track the jobs, and
    cancel all jobs for a particular Change # when a new patch set is uploaded
    but only remove the exact job when remove() is called.
    
    There was also a problem in calling Future.cancel(), as documented in
    https://issues.jenkins-ci.org/browse/JENKINS-13829.  This was worked around
    by storing the parameters used to create each build and canceling jobs with
    the same parameters.  This is more in-line with how jobs are canceled from
    the Web UI.
  2. @TWestling

    Merge pull request #23 from bklarson/master

    TWestling committed
    Fix behavior of canceling old patch sets
Commits on May 22, 2012
  1. @dpursehouse

    Update help text for "build current patches only"

    dpursehouse committed
    Change-Id: I55da2306b9bf688be02f70c15ac4d129eefd2687
  2. @dpursehouse

    Add missing Japanese translations

    dpursehouse committed
    Change-Id: I5e777636e3f6954d4596fd8632771f4cea958252
Commits on May 21, 2012
  1. Fix behavior of canceling old patch sets

    Brad Larson committed
    There were several problems with canceling jobs created by old patch sets
    when new patch sets are uploaded.
    
    We were removing old jobs when scheduled() was called, but then removed()
    was also called, which would cancel the newly-added build we care about.
    Instead, we now store the PatchsetCreated event to track the jobs, and
    cancel all jobs for a particular Change # when a new patch set is uploaded
    but only remove the exact job when remove() is called.
    
    There was also a problem in calling Future.cancel(), as documented in
    https://issues.jenkins-ci.org/browse/JENKINS-13829.  This was worked around
    by storing the parameters used to create each build and canceling jobs with
    the same parameters.  This is more in-line with how jobs are canceled from
    the Web UI.
  2. @dpursehouse

    Make patchset revision available as parameter in verified commands

    dpursehouse committed
    The patchset revision is made available as a parameter in the commands
    that are run when the build is started/successful/unstable/failed.
    
    Also fixed a few typos.
Commits on May 14, 2012
  1. @rsandell

    Backwards compatibility fixes.

    rsandell committed
    Fixed some loading issues with old builds.
    
    Change-Id: I55fd52005a5c55fda0f360db50385720518108ba
Commits on May 11, 2012
  1. @rsandell

    Merge pull request #22 from rinrinne/ja-trans-0409

    rsandell committed
    Improve Japanese translation
  2. @rsandell

    Merge branch 'trigger-on-ref-updated-2' of github.com:jeblair/gerrit-…

    rsandell committed
    …trigger-plugin into jeblair-trigger-on-ref-updated-2
    
    Conflicts:
    	gerrit-events/pom.xml
    	gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/events/PatchsetCreated.java
    	gerrithudsontrigger/pom.xml
    	gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java
    	gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
    	gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java
    	gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
    	gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/PatchSetKeyParameterizedTest.java
    	gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
    	gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
Something went wrong with that request. Please try again.