Added 'dispose' action #135

Merged
merged 2 commits into from Aug 1, 2013

Projects

None yet

2 participants

@ghost
ghost commented Jun 25, 2013
  • use with elements about to be removed from the DOM or that otherwise
    no longer require updating
  • only clears interval; leaves node as-is
  • usage: $('.timeago').timeago('dispose');
@rmm5t
Owner
rmm5t commented Jun 26, 2013

Possible to add tests for this feature?

Dave added some commits Jun 25, 2013
Dave Add 'dispose' action
- use with elements about to be removed from the DOM or that otherwise
no longer require updating
- only clears interval; leaves node as-is
- usage: $('.timeago').timeago('dispose');
3b89571
Dave Add tests for 'dispose' action 1a763d5
@ghost
ghost commented Jul 30, 2013

Line endings should be good now.

@rmm5t rmm5t merged commit 61980c6 into rmm5t:master Aug 1, 2013
@rmm5t
Owner
rmm5t commented Aug 1, 2013

@enterprisey Thanks! Sorry for the delay on this one. I'll try to get an official release out this week that incorporates this change too.

@philfreo
philfreo commented Aug 1, 2013

@rmm5t along the same lines as dispose (not having extra timers, etc. around), can you take a look at #30 which (even when not using jquery-live) or similar so that calling autosave() multiple times (when new portions of the dom are rendered/re-rendered) that multiple instances of autosave don't get instantiated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment