Added shoulda-matchers support #4

Merged
merged 1 commit into from Jan 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

mkaschenko commented Mar 20, 2012

No description provided.

Owner

rmm5t commented Mar 21, 2012

Thanks for this. I'll review this more and pull this as soon as I can. I'll likely deprecate the old shoulda macros too.

Contributor

mkaschenko commented Mar 21, 2012

I think it { should strip_attributes } should tests default behavior of AM's strip_attributes without arguments. Now always it returns true.

@rmm5t rmm5t added a commit that referenced this pull request Jan 25, 2013

@rmm5t rmm5t Merge pull request #4 from mkaschenko/shoulda_matchers_support
Added shoulda-matchers support
018b2de

@rmm5t rmm5t merged commit 2620c06 into rmm5t:master Jan 25, 2013

Owner

rmm5t commented Jan 25, 2013

@mkaschenko Sorry this took so long, but I pulled in your matcher addition.

However, I did change the behavior to only work on one attribute at a time. I also moved the matcher to strip_attributes/matchers. See the Testing section of the readme for more info.

Thanks for your work on this. It's a big improvement.

mkaschenko deleted the mkaschenko:shoulda_matchers_support branch Jan 27, 2013

Contributor

mkaschenko commented Jan 27, 2013

I've viewed your addition and I also think the new behavior is better. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment