Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plugin translation via translate.wordpress.org #62

Closed
tobifjellner opened this issue Apr 10, 2020 · 3 comments
Closed

Enable plugin translation via translate.wordpress.org #62

tobifjellner opened this issue Apr 10, 2020 · 3 comments

Comments

@tobifjellner
Copy link

Some small fixes are needed in order to enable translation of this plugin at translate.wordpress.org:

Reference: https://wp-info.org/tools/checkplugini18n.php?slug=search-filter

  1. Your text-domain must be equal to the plugin slug. In the declaration and in every call to the translation functions, you need to use: "search-filter" instead of "searchfilter".

  2. I didn't search your code to check if you're calling load_plugin_textdomain() correctly. But if you set "Requires at least" in Readme to 4.6 or later (which by now should be a rather safe thing to do), then you don't need that command.

@tobifjellner
Copy link
Author

Closing this one. I can see that you've ignored a PR from Ramiy 3.5 years ago, and that strings in the plugin still even don't call the translation functions.

@rmorse
Copy link
Owner

rmorse commented Apr 10, 2020

Hey @tobifjellner , I'm about 3 weeks away from dropping a complete rewrite - this version of the plugin has been neglegted for far too long - and strings will be properly translatable :)

@tobifjellner
Copy link
Author

Thanks. I'll bring the good news to a Swedish user that was trying to translate your plugin to Swedish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants