Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some Ruby 2.7 deprecation warnings. #2653
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
I fixed a few more and that reduced the output for the graphql-ruby CI job by ~200 lines. The remaining ones are pretty weird, so I'm tapping out :P @rmosolgo Hopefully this is helpful! And no rush, please enjoy your Christmas :) |
This comment has been minimized.
This comment has been minimized.
|
Thanks for knocking out so many of these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
connorshea commentedDec 21, 2019
•
edited
Fixes part of #2650. This fixes all the deprecations that I had when running graphql-ruby with my Rails app, and removes almost 1000 deprecation warnings from my test suite. Looking at the travis logs for ruby-head there are some deprecation warnings my changes don't seem to fix. A lot of the deprecations from ruby-head in travis are external libraries that can be fixed by just updating them, e.g. rake, rails, and rubocop.