Skip to content

Clarify arrays.remove test case #38

merged 1 commit into from Jul 10, 2012

2 participants


According to my understanding, the second argument to arrays.remove is a value, not an index. The proposed change clarifies this meaning (in the description) and makes sure that the implementation removes all occurrences of the value from the array.

Since the test case is ambigous both in description and in code, we might as well clarify to request the opposite behavior, i. e. removing only the first occurence of the value. In any way, the test case should settle on either of both possible functionalities.

@rmurphey rmurphey merged commit e4cb0d6 into rmurphey:master Jul 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.