Make sure that the passed functions are called #40

Merged
merged 2 commits into from Jul 26, 2012

Projects

None yet

2 participants

@adrianheine
Contributor

Without looking at the test’s source, I for one ignored the first argument
to functions.partial.

It would be much nicer to have a meaningful failure message, but I guess expect.js doesn’t allow that?

@adrianheine adrianheine Make sure that the passed functions are called
Without looking at the test’s source, I for one ignored the first argument
to functions.partial.
d48e47b
@rmurphey rmurphey and 1 other commented on an outdated diff Jul 11, 2012
tests/app/functions.js
return greeting + ', ' + name + (punctuation || '!');
};
it("you should be able to use an array as arguments when calling a function", function() {
+ sayItCalled = false;
@rmurphey
rmurphey Jul 11, 2012 Owner

ideally this would go in a beforeEach since it's needed for every test

@adrianheine
adrianheine Jul 11, 2012 Contributor

Did that, thanks for the suggestion :)

@rmurphey rmurphey merged commit c695be6 into rmurphey:master Jul 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment