arrays: remove() without copy and name array.removeWithCopy() #58

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@Krinkle

Krinkle commented Jan 2, 2013

The default should be assumed to not make a copy. Making a copy is a special case (or it should be called "without" instead or "remove").

See also issue #55.

@rmurphey

View changes

tests/app/arrays.js
});
- it("you should be able to remove a value from an array, returning the original array", function() {
+ it("you should be able to remove a value from an array, without changing the original array", function() {

This comment has been minimized.

@rmurphey

rmurphey Jan 2, 2013

Owner

How about

it("you should be able to return a copy of an array with certain values removed", function() {
@rmurphey

rmurphey Jan 2, 2013

Owner

How about

it("you should be able to return a copy of an array with certain values removed", function() {

This comment has been minimized.

@rmurphey

This comment has been minimized.

Show comment
Hide comment
@rmurphey

rmurphey Jan 2, 2013

Owner

This should address #55. It would be great to get a pull request on the answers repo as well so that they stay in sync.

Owner

rmurphey commented Jan 2, 2013

This should address #55. It would be great to get a pull request on the answers repo as well so that they stay in sync.

@Krinkle

This comment has been minimized.

Show comment
Hide comment
@Krinkle

Krinkle Jan 3, 2013

Could you merge pull #56 first?

Krinkle commented Jan 3, 2013

Could you merge pull #56 first?

Krinkle added some commits Jan 3, 2013

arrays: remove() without copy and name array.removeWithCopy()
The default should be assumed to not make a copy. Making
a copy is a special case (or it should be called "without"
instead or "remove").
@Krinkle

This comment has been minimized.

Show comment
Hide comment

Krinkle commented Mar 6, 2013

See #59.

@Krinkle Krinkle closed this Mar 6, 2013

@beeeswax

This comment has been minimized.

Show comment
Hide comment
@beeeswax

beeeswax May 31, 2013

Contributor

I was just about to submit a pull request for this same change! 😄

Contributor

beeeswax commented on 270313c May 31, 2013

I was just about to submit a pull request for this same change! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment