arrays: Add documentation, stricter tests #59

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

Krinkle commented Jan 2, 2013

Add some documentation to clarify the intended return value. It isn't always obvious that the return value should be the array. Given that Array#push(), for example, returns the length.

And stricter tests to make sure a copy is returned when expected, and in other case the original was affected.

Krinkle added some commits Jan 3, 2013

@Krinkle Krinkle tests/arrays: Assert that result does not equal original. 270313c
@Krinkle Krinkle arrays: remove() without copy and name array.removeWithCopy()
The default should be assumed to not make a copy. Making
a copy is a special case (or it should be called "without"
instead or "remove").
f87b018
@Krinkle Krinkle array: Add documentation, stricter tests.
Add some documentation to clarify the intended return value.
It isn't always obvious that the return value should be the
array. Given that Array#push(), for example, returns the length.

And stricter tests to make sure a copy is returned when expected,
and in other case the original was affected.
47e7dbf
Contributor

beeeswax commented on 270313c May 31, 2013

I was just about to submit a pull request for this same change! 😄

Owner

rmurphey commented Jun 7, 2013

I'm really sorry I haven't had a chance to look at this, and now it's not mergeable. If you're willing to forgive me and get this mergeable again, it would be most welcome!

Krinkle closed this Oct 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment