Add a value to the arrays duplicates test array. #68

Merged
merged 1 commit into from Jun 7, 2013

Conversation

Projects
None yet
2 participants
@beeeswax
Contributor

beeeswax commented May 31, 2013

Hi!

First, I want to say thank you so much for putting this together. I am just starting to learn JavaScript and this has been really helpful!

I noticed that the "duplicates" test in arrays had only pairs of duplicates, which let me get away with using a pair of nested for loops. I added another "3" to the test array to prompt people to think about other ways to do this.

This test still passes with your answer in js-assessment-answers so there's no pull request necessary over there.

Thanks again! Have a great weekend.
Matt

Add a value to the arrays duplicates test array.
The test array had only pairs of duplicates, now it has a triplet of 3s.
@rmurphey

This comment has been minimized.

Show comment
Hide comment
@rmurphey

rmurphey Jun 7, 2013

Owner

This is a great addition, thank you!

Owner

rmurphey commented Jun 7, 2013

This is a great addition, thank you!

rmurphey added a commit that referenced this pull request Jun 7, 2013

Merge pull request #68 from beeeswax/arrays-duplicates
Add a value to the arrays duplicates test array.

@rmurphey rmurphey merged commit 716becb into rmurphey:master Jun 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment