Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dist param from bed_closest #182

Closed
jayhesselberth opened this issue Mar 4, 2017 · 0 comments · Fixed by #186
Assignees

Comments

@jayhesselberth
Copy link
Member

@jayhesselberth jayhesselberth commented Mar 4, 2017

And move to examples in the docs.

# make positive strand distances negative
ifelse(res$strand.x == "+", res$.dist, -(res$.dist))

# make all distances positive
res$.dist <- abs(res$.dist) 
@kriemo kriemo self-assigned this Mar 7, 2017
kriemo added a commit to kriemo/valr that referenced this issue Mar 7, 2017
- closes rnabioco#182
- added examples to compute distances in docs
- removed tests referencing distance params
- removed deprecated comments from .cpp code
- repkged docs
@kriemo kriemo added the in progress label Mar 7, 2017
jayhesselberth added a commit that referenced this issue Mar 8, 2017
* Removed distance param for bed_closest
- closes #182
- added examples to compute distances in docs
- removed tests referencing distance params
- removed deprecated comments from .cpp code
- repkged docs

* update globals with .win_id .row_id

* update with dist parameter

* remove warnings from remote db call in valr vignette

* repkged after updating R to remove pkg warnings in vignettes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.