New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple dfs for intersection #220

Closed
jayhesselberth opened this Issue Apr 7, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@jayhesselberth
Collaborator

jayhesselberth commented Apr 7, 2017

Can we use dots to allow multiple ys to be passed into bed_intersect? Would need to internally bind and sort these.

bed_intersect2 <- function(x, ..., invert = FALSE, suffix = c('.x', '.y')) { }

kriemo added a commit to kriemo/valr that referenced this issue Apr 14, 2017

implement bed_intersect2() for multiple y tbl intersection
- also fixes minor bug with passing invert = T and suffixes to
  bed_intersect() and includes relevant test
- add tests for bed_intersect2()
closes rnabioco#220

@kriemo kriemo self-assigned this Apr 14, 2017

@kriemo kriemo added the in progress label Apr 14, 2017

jayhesselberth added a commit that referenced this issue Apr 19, 2017

Update bed_intersect to accept mutiple y tbls (#225)
* implement bed_intersect2() for multiple y tbl intersection
- also fixes minor bug with passing invert = T and suffixes to
  bed_intersect() and includes relevant test
- add tests for bed_intersect2()
- closes #220

* merge bed_intersect2 into bed_intersect
  - reworked bed_window argument parsing due to changing ... behavior
  - reworded bed_window and bed_map documentation due to diverging from bed_intersect
  - updated tests
  - added seed to calls to bed_shuffle in vignettes

* fix to correctly parse supplied arguments when a list of unnamed tbls are supplied.

* replace source.y with .source in output
  - update documentation
  - all additional tests
  - update NEWS

* use SE version to avoid adding another global variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment