New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in bed_shuffle() Issue176 #177

Merged
merged 2 commits into from Mar 4, 2017

Conversation

Projects
None yet
2 participants
@kriemo
Collaborator

kriemo commented Mar 3, 2017

This PR contains a reimplementation of merge_impl which fixes #176

  • The reimplementation is just as fast as the previous implementation
  • The tests for bed_cluster() were testing for the error, so I fixed the test
  • I also added an additional test for bed_merge() for contained intervals
x <- tibble::tribble(
    ~chrom, ~start, ~end,
    'chr1',  1,     10,
    'chr1',  2,     5,
    'chr1',  7,     9
  )

bed_merge(x)
#>  # A tibble: 1 × 3
#>    chrom start   end
#>   <chr> <dbl> <dbl>
#>   1  chr1     1    10

@kriemo kriemo added the in progress label Mar 3, 2017

@jayhesselberth jayhesselberth merged commit 9cb53a7 into rnabioco:master Mar 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kriemo kriemo deleted the kriemo:issue176 branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment