Skip to content
This repository has been archived by the owner on Feb 10, 2019. It is now read-only.

Add the baseurl to the permalinks in the RSS feed #3

Closed
wants to merge 1 commit into from
Closed

Add the baseurl to the permalinks in the RSS feed #3

wants to merge 1 commit into from

Conversation

davidbgk
Copy link

@davidbgk davidbgk commented Jan 5, 2015

Otherwise it leads to 404s like http://blog.garstasio.com/events/

@rnicholus
Copy link
Owner

I'm afraid I don't quite understand the issue here. How can this be reproduced?

@davidbgk
Copy link
Author

davidbgk commented Jan 5, 2015

Sorry I wasn't very explicit here.

When you follow your blog through the RSS feed, you can see that there are permalink with relative ones:

 <link>/events/</link>
 <guid isPermaLink="true">/events/</guid>

It leads to 404s when you click from your RSS reader (e.g. NetNewsWire) because the link is computed from the base url (just the domain name).

I just realized pasting that example that my change is incomplete and you have to modify your url setting too.

@rnicholus
Copy link
Owner

Hmm, you're right. This is an issue. Seems like this is described in jekyll/jekyll#332. Are you confident your change will fix the issue? If not, looks like I'll need to spend some time investigating further when I get some more free time.

@davidbgk
Copy link
Author

davidbgk commented Jan 5, 2015

I'm not confident given that I didn't test it. But, my change will add the baseurl which looks better than the actual 404 URL, note that you have to mention the url setting in your _config.yml to fix the bug completely and get a fully qualified URL/permalink.

@rnicholus rnicholus closed this in 61b9aa0 Jan 5, 2015
@rnicholus
Copy link
Owner

i combined your fix with adjustments to the config.yml. looks good now. Thanks for finding this and providing help.

@davidbgk
Copy link
Author

davidbgk commented Jan 5, 2015

I confirm that it works now in my agregator, it was mostly a selfish help :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants