This repository was archived by the owner on Jul 15, 2022. It is now read-only.
Fix incorrect function call in appendElements #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch thanks! |
ppold
added a commit
that referenced
this pull request
Dec 4, 2014
Fix incorrect function call in appendElements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thank you for open-sourcing and maintaining salvatorre.js. Its been really useful for me! 🍻
I was encountering an error in the current version, when trying to call
appendElements. After digging into it, it looks like its trying to invokenext_element_column_index, which doesn't exist:I've changed the function call to match the function name already defined.
Thanks!