Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow raw encryption. #1807

Merged
merged 7 commits into from Apr 29, 2022
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Apr 26, 2022

This would allow encryption of the already signed message via FFI and CLI.
Fixes #1795

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1807 (6944d43) into master (23a440b) will decrease coverage by 0.00%.
The diff coverage is 83.72%.

❗ Current head 6944d43 differs from pull request most recent head c12d6a5. Consider uploading reports for the commit c12d6a5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
- Coverage   81.14%   81.14%   -0.01%     
==========================================
  Files         138      138              
  Lines       28770    28777       +7     
==========================================
+ Hits        23346    23350       +4     
- Misses       5424     5427       +3     
Impacted Files Coverage Δ
src/librepgp/stream-ctx.h 100.00% <ø> (ø)
src/rnp/fficli.cpp 76.47% <0.00%> (-0.10%) ⬇️
src/tests/ffi-enc.cpp 82.64% <76.47%> (-0.36%) ⬇️
src/lib/rnp.cpp 78.66% <80.00%> (+<0.01%) ⬆️
src/librepgp/stream-write.cpp 76.96% <89.58%> (+0.09%) ⬆️
src/rnp/rnp.cpp 79.07% <100.00%> (+0.30%) ⬆️
src/rnp/rnpcfg.cpp 79.51% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a440b...c12d6a5. Read the comment docs.

@ni4 ni4 force-pushed the ni4-1795-allow-raw-encrypt branch 2 times, most recently from 55f8635 to b005a79 Compare April 28, 2022 09:38
@antonsviridenko
Copy link
Contributor

"No wrap" looks ambiguous, maybe "--no-literal-data-packet" or something more explicit and meaningful?

@ni4
Copy link
Contributor Author

ni4 commented Apr 28, 2022

"No wrap" looks ambiguous, maybe "--no-literal-data-packet" or something more explicit and meaningful?

That one is too long as for me. I was guided by GnuPG's --unwrap key. Basically, user should not know details of the underlying process, just understand why this command is could be usefull for him, so easier wording could be beneficial. But still good subject to discuss )

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ni4 @andrey-utkin !

@ronaldtse ronaldtse merged commit d0901bc into master Apr 29, 2022
@ronaldtse ronaldtse deleted the ni4-1795-allow-raw-encrypt branch April 29, 2022 13:21
@ni4 ni4 added this to the v0.16.1 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI: add API function/flag to do raw encryption of the input.
4 participants