From e5f242f6468259abd6b15c2373f391ae9f5d3532 Mon Sep 17 00:00:00 2001 From: "Maxim [maxirmx] Samsonov" Date: Sat, 24 Jun 2023 23:28:32 +0300 Subject: [PATCH] Created new coverity/codecov/lint environment for sexpp project, fixed coverity CID 453360 --- .github/workflows/coverity.yml | 6 +----- .github/workflows/lint.yml | 16 ++++++++-------- README.adoc | 4 ++-- include/sexpp/sexp-error.h | 2 +- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index 2046b1e..ad9c668 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -37,8 +37,8 @@ jobs: env: CC: gcc CXX: g++ - COVERITY_TOKEN: qjcM1CWLcq9PJB3yL0ZXIw MAKEFLAGS: j4 + TOKEN: qjcM1CWLcq9PJB3yL0ZXIw steps: - name: Checkout uses: actions/checkout@v3 @@ -56,8 +56,6 @@ jobs: run: cmake -Bbuild -DDOWNLOAD_GTEST=OFF - name: Download Coverity - env: - TOKEN: AK2euT-neBcvZB1g_m3pbg run: | wget -q https://scan.coverity.com/download/cxx/linux64 --post-data "token=$TOKEN&project=$GITHUB_REPOSITORY" -O cov-analysis-linux64.tar.gz mkdir cov-analysis-linux64 @@ -70,8 +68,6 @@ jobs: cov-build --dir cov-int cmake --build build - name: Submit - env: - TOKEN: AK2euT-neBcvZB1g_m3pbg run: | tar czvf results.tgz cov-int curl \ diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5e4ba83..0a80e40 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -41,14 +41,14 @@ jobs: source: '.' extensions: 'h,cpp,c' clangFormatVersion: 11 - inplace: True - - uses: EndBug/add-and-commit@v9 - with: - author_name: A robot on behalf of Maxim Samsonov - author_email: m.samsonov@computer.org - message: 'Committing clang-format changes' - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} +# inplace: True +# - uses: EndBug/add-and-commit@v9 +# with: +# author_name: A robot on behalf of Maxim Samsonov +# author_email: m.samsonov@computer.org +# message: 'Committing clang-format changes' +# env: +# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} shellcheck: runs-on: ubuntu-latest steps: diff --git a/README.adoc b/README.adoc index 1570325..765685c 100644 --- a/README.adoc +++ b/README.adoc @@ -6,8 +6,8 @@ image:https://github.com/rnpgp/sexp/workflows/build-and-test-deb/badge.svg["Buil image:https://github.com/rnpgp/sexp/workflows/build-and-test-msys/badge.svg["Build status MSys", link="https://github.com/rnpgp/sexp/actions?workflow=build-and-test-msys"] -image:https://codecov.io/gh/rnpgp/sexp/branch/feat/g23/graph/badge.svg["Code coverage", link="https://codecov.io/gh/rnpgp/sexpp"] -image:https://github.com/rnpgp/sexp/workflows/CodeQL/badge.svg["CodeQL analysis", link="https://github.com/rnpgp/sexp/actions?workflow=CodeQL"] +image:https://codecov.io/gh/rnpgp/sexpp/branch/main/graph/badge.svg["Code coverage", link="https://codecov.io/gh/rnpgp/sexpp"] +image:https://github.com/rnpgp/sexpp/workflows/CodeQL/badge.svg["CodeQL analysis", link="https://github.com/rnpgp/sexpp/actions?workflow=CodeQL"] image:https://scan.coverity.com/projects/28717/badge.svg["Coverity Scan Build Status", link="https://scan.coverity.com/projects/rnpgp-sexpp"] diff --git a/include/sexpp/sexp-error.h b/include/sexpp/sexp-error.h index f38bc1c..9a40168 100644 --- a/include/sexpp/sexp-error.h +++ b/include/sexpp/sexp-error.h @@ -48,7 +48,7 @@ class sexp_exception_t : public std::exception { int error_position, const char *prefix = "SEXP") : position{error_position}, level{error_level}, - message{format(prefix, error_message, error_level, error_position)} {}; + message{format(prefix, std::move(error_message), error_level, error_position)} {}; static std::string format(std::string prf, std::string message,