diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/BaseCheckTestSupport.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/BaseCheckTestSupport.java index 7fcb7ff230..977c41ae88 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/BaseCheckTestSupport.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/BaseCheckTestSupport.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle; import static java.text.MessageFormat.format; +import static org.junit.Assert.assertEquals; import java.io.BufferedReader; import java.io.ByteArrayInputStream; @@ -34,8 +35,6 @@ import java.util.Locale; import java.util.Properties; -import org.junit.Assert; - import com.google.common.collect.Lists; import com.puppycrawl.tools.checkstyle.AuditEventUtFormatter; import com.puppycrawl.tools.checkstyle.Checker; @@ -45,7 +44,7 @@ import com.puppycrawl.tools.checkstyle.api.AuditEvent; import com.puppycrawl.tools.checkstyle.api.Configuration; -public abstract class BaseCheckTestSupport extends Assert { +public abstract class BaseCheckTestSupport { private final ByteArrayOutputStream baos = new ByteArrayOutputStream(); private final PrintStream printStream = new PrintStream(baos); diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/UtilsTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/UtilsTest.java index 35bf245219..4f4dda14f0 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/UtilsTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/UtilsTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle; import static com.puppycrawl.tools.checkstyle.internal.TestUtils.assertUtilsClassHasPrivateConstructor; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; @@ -36,6 +37,7 @@ public void testIsProperUtilsClass() throws ReflectiveOperationException { public void testReportInvalidToken() { try { Utils.reportInvalidToken(TokenTypes.CLASS_DEF); + fail(); } catch (IllegalArgumentException ex) { Assert.assertEquals("Found unsupported token: CLASS_DEF", ex.getMessage()); diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheckTest.java index d2307b3885..d3b28b0e44 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.AvoidModifiersForTypesCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheckTest.java index 630f1215bd..60e1bf741f 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.EmptyPublicCtorInClassCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheckTest.java index 096fe0f2d5..ad9e420b5c 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.ForbidCertainImportsCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheckTest.java index 9329561692..aab11c85f5 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.ForbidInstantiationCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheckTest.java index 1e5caefa35..b5e308265c 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.NumericLiteralNeedsUnderscoreCheck.MSG_KEY; +import static org.junit.Assert.fail; import java.io.File; @@ -185,6 +186,7 @@ public void testMinSymbolsBeforeCheckingSwitchReflection() throws Exception { new NumericLiteralNeedsUnderscoreCheck(); final NumericType mockType = PowerMockito.mock(NumericType.class); WhiteboxImpl.invokeMethod(check, "minSymbolsBeforeChecking", mockType); + fail(); } catch (IllegalStateException ex) { Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE)); @@ -198,6 +200,7 @@ public void testMaxSymbolsUntilUnderscoreSwitchReflection() throws Exception { new NumericLiteralNeedsUnderscoreCheck(); final NumericType mockType = PowerMockito.mock(NumericType.class); WhiteboxImpl.invokeMethod(check, "maxSymbolsUntilUnderscore", mockType); + fail(); } catch (IllegalStateException ex) { Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE)); @@ -211,6 +214,7 @@ public void testGetNumericSegmentsSwitchReflection() throws Exception { new NumericLiteralNeedsUnderscoreCheck(); final NumericType mockType = PowerMockito.mock(NumericType.class); WhiteboxImpl.invokeMethod(check, "getNumericSegments", "", mockType); + fail(); } catch (IllegalStateException ex) { Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE)); @@ -224,6 +228,7 @@ public void testRemovePrePostfixByTypeSwitchReflection() throws Exception { new NumericLiteralNeedsUnderscoreCheck(); final NumericType mockType = PowerMockito.mock(NumericType.class); WhiteboxImpl.invokeMethod(check, "removePrePostfixByType", "", mockType); + fail(); } catch (IllegalStateException ex) { Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE)); diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheckTest.java index f3089e34ff..4689cd800c 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.RedundantReturnCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheckTest.java index 6741d55aad..8e8916569f 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.RequireFailForTryCatchInJunitCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheckTest.java index 9787d776d9..9bb3c490b7 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.coding; import static com.github.sevntu.checkstyle.checks.coding.ReturnNullInsteadOfBooleanCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheckTest.java index ca025acdcf..39f44a819b 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.design; import static com.github.sevntu.checkstyle.checks.design.AvoidConditionInversionCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheckTest.java index 415a825888..8bd8881674 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.design; import static com.github.sevntu.checkstyle.checks.design.CauseParameterInExceptionCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheckTest.java index 8cbd438682..6534a89cce 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.design; import static com.github.sevntu.checkstyle.checks.design.ConstructorWithoutParamsCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; import org.junit.Before; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheckTest.java index 539d45d37c..61aa059fa5 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.design; import static com.github.sevntu.checkstyle.checks.design.PublicReferenceToPrivateTypeCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheckTest.java index 2e0f0b919c..09e66debd5 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.design; import static com.github.sevntu.checkstyle.checks.design.StaticMethodCandidateCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; import java.io.File; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheckTest.java index c12c317997..46e46364e4 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheckTest.java @@ -19,6 +19,8 @@ package com.github.sevntu.checkstyle.checks.naming; +import static org.junit.Assert.fail; + import java.util.Arrays; import org.junit.Assert; diff --git a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheckTest.java b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheckTest.java index 7c3d271990..fb8742302e 100644 --- a/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheckTest.java +++ b/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheckTest.java @@ -20,6 +20,7 @@ package com.github.sevntu.checkstyle.checks.sizes; import static com.github.sevntu.checkstyle.checks.sizes.LineLengthExtendedCheck.MSG_KEY; +import static org.junit.Assert.fail; import org.junit.Assert; import org.junit.Test; @@ -86,6 +87,7 @@ public void testProperty() throws Exception { try { verify(checkConfig, getPath("InputLineLengthExtendedCheck.java"), expected); + fail(); } catch (CheckstyleException ex) { Assert.assertTrue(ex.getMessage().startsWith("cannot initialize module "