Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I've finally made this. The user can now login using their credentials. The login information is stored in the shared session which persists across the app's relaunches. There's a bar item button for login/logout, a login view and network tools for the feature.
The HNService class was modified a little bit for two reasons:
I hope the changes feel well. If anything (hopefully that won't be the whole request though) isn't consistent with the app's design I would love to modify it.
…ppendingPathComponent doesn't work with URLs changing "https://news.ycombinator.com" to "https:/news.ycombinator.com" making it not working with cookies (domain mismatch).
@stansidel Hey man! So I took a look and this is really great! I think that I will merge this, but likely strip out some things. For starters, I would like to make the login VC a tab. Once you login, you'll see a "profile" VC that you can then look at your posts/comments from.
Is that ok? I'll make sure to leave your name in the files that are used, even if rearranged a bit.