Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type hinting prevents upgrading Roadiz to Symfony >5.0 #365

Closed
ambroisemaupate opened this issue Jun 2, 2020 · 1 comment
Closed

Comments

@ambroisemaupate
Copy link
Member

ambroisemaupate commented Jun 2, 2020

symfony/symfony#37062

UrlGeneratorInterface only accepts string route names. This will break the entire Node-source routing system.

@ambroisemaupate
Copy link
Member Author

ambroisemaupate commented Jun 2, 2020

  • Upgrade symfony-cmf/routing to ~2.3.2 to get deprecation notices about passing object to generate method
  • Upgrade generate usage to RouteObjectInterface::OBJECT_BASED_ROUTE_NAME in Roadiz backend
  • Override Symfony\Bridge\Twig\Extension\RoutingExtension to add compatibility layer for object based routing.
  • Upgrade all Abstract Roadiz Themes that could inject new Router into ChainRouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant