feat!: Implement health check API using HealthCheck trait - #255
Merged
Conversation
- Use the `HealthCheck` trait to implement the `_health` API endpoint and the health CLI command in addition to pre-boot checks. - Create a `HealthCheckRegistry` and the `App#health_checks method to allow consumers to provide their own health checks that will be run along with the defualt ones. - Remove the health checks from the `ServiceRegistry`. Closes #241
spencewenski
force-pushed
the
gh-241-health-check-in-api
branch
from
July 1, 2024 10:20
8f3fcaf to
4fb79e9
Compare
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
pushed a commit
that referenced
this pull request
Jul 1, 2024
## 🤖 New release * `roadster`: 0.3.5 -> 0.4.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.0](roadster-v0.3.5...roadster-v0.4.0) - 2024-07-01 ### Added - [**breaking**] Implement health check API using `HealthCheck` trait ([#255](#255)) - [**breaking**] Switch to Axum's `FromRef` for custom state ([#250](#250)) ### Other - [**breaking**] Remove deprecated items in preparation of 0.4 release ([#253](#253)) - Add example for integrating with Leptos ([#252](#252)) - Use small number of sidekiq workers for `full` example in dev/test ([#251](#251)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HealthChecktrait to implement the_healthAPI endpoint and the health CLI command in addition to pre-boot checks.HealthCheckRegistryand the `App#health_checks method to allow consumers to provide their own health checks that will be run along with the defualt ones.ServiceRegistry.Closes #241