chore: Disallow unwrap and expect except in tests - #286
Merged
Conversation
There are a couple places where we do allow `expect`, but these places should mainly be during boot up and not during normal app operations, and their usage should be minimal.
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
pushed a commit
that referenced
this pull request
Jul 24, 2024
## 🤖 New release * `roadster`: 0.5.8 -> 0.5.9 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.9](roadster-v0.5.8...roadster-v0.5.9) - 2024-07-24 ### Added - Auto-update timestamp columns ([#287](#287)) - Add SeaORM migrations and utils to create `user` table ([#284](#284)) ### Other - Disallow `unwrap` and `expect` except in tests ([#286](#286)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple places where we do allow
expect, but these places should mainly be during boot up and not during normal app operations, and their usage should be minimal.